Skip to content

Relax generic package filename restrictions #30135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 27, 2024
Merged

Relax generic package filename restrictions #30135

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f756fc7
fix
wxiaoguang Mar 27, 2024
9486f28
improve regex, fix tests
wxiaoguang Mar 27, 2024
c90ad79
more tests
wxiaoguang Mar 27, 2024
d417e36
fix lint
wxiaoguang Mar 27, 2024
20dcd38
fix test
wxiaoguang Mar 27, 2024
394960a
Merge branch 'main' into fix-package-name
KN4CK3R Mar 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions routers/api/packages/generic/generic.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@ import (
)

var (
packageNameRegex = regexp.MustCompile(`\A[A-Za-z0-9\.\_\-\+]+\z`)
filenameRegex = packageNameRegex
packageNameRegex = regexp.MustCompile(`\A[-_+.A-Za-z0-9]+\z`)
filenameRegex = regexp.MustCompile(`\A[-_+=:;.()\[\]{}~!@#$%^& A-Za-z0-9]+\z`)
)

func apiError(ctx *context.Context, status int, obj any) {
Expand Down