Disable run user change in installation page

Author: lunny

options/locale/locale_en-US.ini

@@ -224,7 +224,7 @@ repo_path_helper = Remote Git repositories will be saved to this directory.
 lfs_path = Git LFS Root Path
 lfs_path_helper = Files tracked by Git LFS will be stored in this directory. Leave empty to disable.
 run_user = Run As Username
-run_user_helper = Enter the operating system username that Gitea runs as. Note that this user must have access to the repository root path.
+run_user_helper = The operating system username that Gitea runs as. Note that this user must have access to the repository root path.
 domain = Server Domain
 domain_helper = Domain or host address for the server.
 ssh_port = SSH Server Port

routers/install/install.go

@@ -120,10 +120,13 @@ func Install(ctx *context.Context) {
 
 	// Note(unknown): it's hard for Windows users change a running user,
 	// 	so just use current one if config says default.
-	if setting.IsWindows && setting.RunUser == "git" {
-		form.RunUser = user.CurrentUsername()
-	} else {
+	if setting.RunUser != "" {
 		form.RunUser = setting.RunUser
+	} else {
+		form.RunUser = user.CurrentUsername()
+		if form.RunUser == "" {
+			form.RunUser = "git"
+		}
 	}
 
 	form.Domain = setting.Domain

templates/install.tmpl

@@ -119,7 +119,7 @@
 					</div>
 					<div class="inline required field {{if .Err_RunUser}}error{{end}}">
 						<label for="run_user">{{.locale.Tr "install.run_user"}}</label>
-						<input id="run_user" name="run_user" value="{{.run_user}}" required>
+						<input id="run_user" name="run_user" value="{{.run_user}}" disabled>
 						<span class="help">{{.locale.Tr "install.run_user_helper"}}</span>
 					</div>
 					<div class="inline required field">