Skip to content

Commit 715a977

Browse files
silverwindsilverwind
committed
Timeline and color tweaks
- Restore muted effect on timeline author and issuelist comment icon - Remove whitespace inside shared user templates, fixing link hover underline - Use shared author link template more - Use `bold` class instead of CSS - Fix grey-light color being too dark on arc-green - Add missing black-light color - Fix issuelist progress bar color
1 parent 6f3efdf commit 715a977

File tree

12 files changed

+35
-37
lines changed

12 files changed

+35
-37
lines changed

‎templates/repo/diff/comments.tmpl‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
<div class="ui top attached header comment-header df ac sb">
1212
<div class="comment-header-left df ac">
1313
{{if .OriginalAuthor}}
14-
<span class="text black mr-2">
14+
<span class="text black bold mr-2">
1515
{{svg (MigrationIcon $.root.Repository.GetOriginalURLHostname)}}
1616
{{.OriginalAuthor}}
1717
</span>

‎templates/repo/issue/view_content.tmpl‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@
3030
<div class="ui top attached header comment-header df ac sb">
3131
<div class="comment-header-left df ac">
3232
{{if .Issue.OriginalAuthor}}
33-
<span class="text black">
33+
<span class="text black bold">
3434
{{svg (MigrationIcon .Repository.GetOriginalURLHostname)}}
3535
{{.Issue.OriginalAuthor}}
3636
</span>
@@ -45,7 +45,7 @@
4545
{{avatar .Issue.Poster}}
4646
</a>
4747
<span class="text grey">
48-
<a class="author"{{if gt .Issue.Poster.ID 0}} href="{{.Issue.Poster.HomeLink}}"{{end}}>{{.Issue.Poster.GetDisplayName}}</a>
48+
{{template "shared/user/authorlink" .Issue.Poster}}
4949
{{.locale.Tr "repo.issues.commented_at" (.Issue.HashTag|Escape) $createdStr | Safe}}
5050
</span>
5151
{{end}}

‎templates/repo/issue/view_content/comments.tmpl‎

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525
<div class="ui top attached header comment-header df ac sb">
2626
<div class="comment-header-left df ac">
2727
{{if .OriginalAuthor}}
28-
<span class="text black mr-2">
28+
<span class="text black bold mr-2">
2929
{{svg (MigrationIcon $.Repository.GetOriginalURLHostname)}}
3030
{{.OriginalAuthor}}
3131
</span>
@@ -42,9 +42,7 @@
4242
</a>
4343
{{end}}
4444
<span class="text grey">
45-
<a class="author"{{if gt .Poster.ID 0}} href="{{.Poster.HomeLink}}"{{end}}>
46-
{{.Poster.GetDisplayName}}
47-
</a>
45+
{{template "shared/user/authorlink" .Poster}}
4846
{{$.locale.Tr "repo.issues.commented_at" (.HashTag|Escape) $createdStr | Safe}}
4947
</span>
5048
{{end}}
@@ -207,7 +205,7 @@
207205
{{if .RemovedAssignee}}
208206
{{template "shared/user/avatarlink" .Assignee}}
209207
<span class="text grey">
210-
<a class="author" {{if gt .Assignee.ID 0}}href="{{.Assignee.HomeLink}}"{{end}}>{{.Assignee.GetDisplayName}}</a>
208+
{{template "shared/user/authorlink" .Assignee}}
211209
{{if eq .Poster.ID .Assignee.ID}}
212210
{{$.locale.Tr "repo.issues.remove_self_assignment" $createdStr | Safe}}
213211
{{else}}
@@ -408,7 +406,7 @@
408406
<div class="comment-header-left df ac">
409407
<span class="text grey">
410408
{{if .OriginalAuthor}}
411-
<span class="text black">
409+
<span class="text black bold">
412410
{{svg (MigrationIcon $.Repository.GetOriginalURLHostname)}}
413411
{{.OriginalAuthor}}
414412
</span>
@@ -536,7 +534,7 @@
536534
{{end}}
537535
<span class="text grey">
538536
{{if .OriginalAuthor}}
539-
<span class="text black">
537+
<span class="text black bold">
540538
{{svg (MigrationIcon $.Repository.GetOriginalURLHostname)}}
541539
{{.OriginalAuthor}}
542540
</span>

‎templates/repo/issue/view_content/sidebar.tmpl‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -389,7 +389,7 @@
389389
{{avatar $user}}
390390
</a>
391391
<div class="content">
392-
<a class="author">{{$user.DisplayName}}</a>
392+
{{template "shared/user/authorlink" $user}}
393393
<div class="text">
394394
{{$trackedtime}}
395395
</div>

‎templates/shared/issuelist.tmpl‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -160,7 +160,7 @@
160160
</div>
161161
<div class="issue-item-icon-right text grey">
162162
{{if .NumComments}}
163-
<a class="tdn" href="{{if .HTMLURL}}{{.HTMLURL}}{{else}}{{$.Link}}/{{.Index}}{{end}}">
163+
<a class="tdn muted" href="{{if .HTMLURL}}{{.HTMLURL}}{{else}}{{$.Link}}/{{.Index}}{{end}}">
164164
{{svg "octicon-comment" 16 "mr-2"}}{{.NumComments}}
165165
</a>
166166
{{end}}

‎templates/shared/user/authorlink.tmpl‎

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1 @@
1-
<a class="author"{{if gt .ID 0}} href="{{.HomeLink}}"{{end}}>
2-
{{.GetDisplayName}}
3-
</a>
1+
<a class="author text black bold muted"{{if gt .ID 0}} href="{{.HomeLink}}"{{end}}>{{.GetDisplayName}}</a>

‎templates/shared/user/avatarlink.tmpl‎

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1 @@
1-
<a class="avatar"{{if gt .ID 0}} href="{{.HomeLink}}"{{end}}>
2-
{{avatar .}}
3-
</a>
1+
<a class="avatar"{{if gt .ID 0}} href="{{.HomeLink}}"{{end}}>{{avatar .}}</a>

‎templates/shared/user/namelink.tmpl‎

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1 @@
1-
<a{{if gt .ID 0}} href="{{.HomeLink}}"{{end}}>
2-
{{.GetDisplayName}}
3-
</a>
1+
<a{{if gt .ID 0}} href="{{.HomeLink}}"{{end}}>{{.GetDisplayName}}</a>

‎web_src/less/_base.less‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,6 +79,7 @@
7979
--color-pink: #e03997;
8080
--color-brown: #a5673f;
8181
--color-grey: #888888;
82+
--color-black: #1b1c1d;
8283
/* light variants - produced via Sass scale-color(color, $lightness: +25%) */
8384
--color-red-light: #e45e5e;
8485
--color-orange-light: #f59555;
@@ -92,9 +93,9 @@
9293
--color-pink-light: #e86bb1;
9394
--color-brown-light: #c58b66;
9495
--color-grey-light: #a6a6a6;
96+
--color-black-light: #525558;
9597
/* other colors */
9698
--color-gold: #a1882b;
97-
--color-black: #1b1c1d;
9899
--color-white: #ffffff;
99100
--color-diff-removed-word-bg: #fdb8c0;
100101
--color-diff-added-word-bg: #acf2bd;

‎web_src/less/_repository.less‎

Lines changed: 7 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -829,7 +829,7 @@
829829

830830
.timeline-avatar {
831831
position: absolute;
832-
left: -72px;
832+
left: -68px;
833833

834834
img {
835835
width: 40px !important;
@@ -846,7 +846,6 @@
846846
.avatar img {
847847
width: 20px;
848848
height: 20px;
849-
margin: 0 .25rem;
850849
vertical-align: middle;
851850
}
852851

@@ -981,10 +980,6 @@
981980
margin-top: 4px;
982981
}
983982

984-
.author {
985-
font-weight: 600;
986-
}
987-
988983
.comment-form-reply .footer {
989984
padding-bottom: 1em;
990985
}
@@ -1165,9 +1160,12 @@
11651160
padding-left: 15px;
11661161

11671162
.detail {
1168-
font-size: .9rem;
1169-
margin-top: 5px;
1170-
margin-left: 8px;
1163+
margin-top: 4px;
1164+
margin-left: 14px;
1165+
1166+
.svg {
1167+
margin-right: 2px;
1168+
}
11711169
}
11721170

11731171
.segments {
@@ -2723,12 +2721,10 @@
27232721

27242722
a {
27252723
color: var(--color-text);
2726-
text-decoration: none;
27272724
}
27282725

27292726
a:hover {
27302727
color: var(--color-primary);
2731-
text-decoration: none;
27322728
}
27332729
}
27342730

0 commit comments

Comments
 (0)