PR feedback

Author: kemzeb

routers/web/repo/release.go

@@ -489,7 +489,7 @@ func NewReleasePost(ctx *context.Context) {
 			return
 		}
 	} else {
-		if len(form.TagOnly) > 0 && rel.IsTag {
+		if form.TagOnly != "" && rel.IsTag {
 			ctx.Data["Err_TagName"] = true
 			ctx.RenderWithErr(ctx.Tr("repo.release.tag_name_already_exist"), tplReleaseNew, &form)
 			return

routers/web/repo/release_test.go

@@ -22,19 +22,32 @@ func TestNewReleasePost(t *testing.T) {
 		RepoID  int64
 		UserID  int64
 		TagName string
+		IsTag   bool
 		Form    forms.NewReleaseForm
 	}{
-		{
+		{ // pre-existing tag
 			RepoID:  1,
 			UserID:  2,
-			TagName: "v1.1", // pre-existing tag
+			TagName: "v1.1",
 			Form: forms.NewReleaseForm{
 				TagName: "newtag",
 				Target:  "master",
 				Title:   "title",
 				Content: "content",
 			},
 		},
+		{ // creating a new tag when there's already a pre-existing tag
+			RepoID:  1,
+			UserID:  2,
+			TagName: "delete-tag",
+			IsTag:   true,
+			Form: forms.NewReleaseForm{
+				TagName: "delete-tag",
+				Target:  "master",
+				Title:   "delete-tag",
+				TagOnly: "1",
+			},
+		},
 		{
 			RepoID:  1,
 			UserID:  2,
@@ -62,6 +75,7 @@ func TestNewReleasePost(t *testing.T) {
 			Target:      testCase.Form.Target,
 			Title:       testCase.Form.Title,
 			Note:        testCase.Form.Content,
+			IsTag:       true,
 		}, unittest.Cond("is_draft=?", len(testCase.Form.Draft) > 0))
 		ctx.Repo.GitRepo.Close()
 	}