Skip to content

Commit 1f49ee4

Browse files
65436543
committed
API: Add repoGetTag
1 parent 1189bf8 commit 1f49ee4

File tree

4 files changed

+120
-26
lines changed

4 files changed

+120
-26
lines changed

‎integrations/api_repo_tags_test.go‎

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,20 @@ func TestAPIRepoTags(t *testing.T) {
5151
assert.EqualValues(t, newTag.Commit.SHA, tag.Commit.SHA)
5252
}
5353
}
54+
55+
// get created tag
56+
req = NewRequestf(t, "GET", "/api/v1/repos/%s/%s/tags/%s?token=%s", user.Name, repoName, newTag.Name, token)
57+
resp = session.MakeRequest(t, req, http.StatusOK)
58+
var tag *api.Tag
59+
DecodeJSON(t, resp, &tag)
60+
assert.EqualValues(t, newTag, tag)
61+
62+
// delete tag
63+
delReq := NewRequestf(t, "DELETE", "/api/v1/repos/%s/%s/tags/%s?token=%s", user.Name, repoName, newTag.Name, token)
64+
resp = session.MakeRequest(t, delReq, http.StatusNoContent)
65+
66+
// check if it's gone
67+
resp = session.MakeRequest(t, req, http.StatusNotFound)
5468
}
5569

5670
func createNewTagUsingAPI(t *testing.T, session *TestSession, token string, ownerName, repoName, name, target, msg string) *api.Tag {

‎routers/api/v1/api.go‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -775,6 +775,7 @@ func Routes() *web.Route {
775775
}, reqToken(), reqAdmin())
776776
m.Group("/tags", func() {
777777
m.Get("", repo.ListTags)
778+
m.Get("/{tag}", repo.GetTag)
778779
m.Post("", reqRepoWriter(models.UnitTypeCode), bind(api.CreateTagOption{}), repo.CreateTag)
779780
m.Delete("/{tag}", repo.DeleteTag)
780781
}, reqRepoReader(models.UnitTypeCode), context.ReferencesGitRepo(true))

‎routers/api/v1/repo/tag.go‎

Lines changed: 63 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -110,11 +110,11 @@ func GetAnnotatedTag(ctx *context.APIContext) {
110110
}
111111
}
112112

113-
// DeleteTag delete a specific tag of in a repository by name
114-
func DeleteTag(ctx *context.APIContext) {
115-
// swagger:operation DELETE /repos/{owner}/{repo}/tags/{tag} repository repoDeleteTag
113+
// GetTag get the tag of a repository
114+
func GetTag(ctx *context.APIContext) {
115+
// swagger:operation GET /repos/{owner}/{repo}/tags/{tag} repository repoGetTag
116116
// ---
117-
// summary: Delete a repository's tag by name
117+
// summary: Get the tag of a repository by tag name
118118
// produces:
119119
// - application/json
120120
// parameters:
@@ -130,37 +130,22 @@ func DeleteTag(ctx *context.APIContext) {
130130
// required: true
131131
// - name: tag
132132
// in: path
133-
// description: name of tag to delete
133+
// description: name of tag
134134
// type: string
135135
// required: true
136136
// responses:
137-
// "204":
137+
// "200":
138138
// "$ref": "#/responses/empty"
139139
// "404":
140140
// "$ref": "#/responses/notFound"
141-
// "409":
142-
// "$ref": "#/responses/conflict"
141+
tagName := ctx.Params("tag")
143142

144-
tag, err := models.GetRelease(ctx.Repo.Repository.ID, ctx.Params("tag"))
143+
tag, err := ctx.Repo.GitRepo.GetTag(tagName)
145144
if err != nil {
146-
if models.IsErrReleaseNotExist(err) {
147-
ctx.NotFound()
148-
return
149-
}
150-
ctx.Error(http.StatusInternalServerError, "GetRelease", err)
151-
return
152-
}
153-
154-
if !tag.IsTag {
155-
ctx.Error(http.StatusConflict, "IsTag", errors.New("a tag attached to a release cannot be deleted directly"))
145+
ctx.NotFound(tagName)
156146
return
157147
}
158-
159-
if err = releaseservice.DeleteReleaseByID(tag.ID, ctx.User, true); err != nil {
160-
ctx.Error(http.StatusInternalServerError, "DeleteReleaseByID", err)
161-
}
162-
163-
ctx.Status(http.StatusNoContent)
148+
ctx.JSON(http.StatusOK, convert.ToTag(ctx.Repo.Repository, tag))
164149
}
165150

166151
// CreateTag create a new git tag in a repository
@@ -221,3 +206,56 @@ func CreateTag(ctx *context.APIContext) {
221206
}
222207
ctx.JSON(http.StatusCreated, convert.ToTag(ctx.Repo.Repository, tag))
223208
}
209+
210+
// DeleteTag delete a specific tag of in a repository by name
211+
func DeleteTag(ctx *context.APIContext) {
212+
// swagger:operation DELETE /repos/{owner}/{repo}/tags/{tag} repository repoDeleteTag
213+
// ---
214+
// summary: Delete a repository's tag by name
215+
// produces:
216+
// - application/json
217+
// parameters:
218+
// - name: owner
219+
// in: path
220+
// description: owner of the repo
221+
// type: string
222+
// required: true
223+
// - name: repo
224+
// in: path
225+
// description: name of the repo
226+
// type: string
227+
// required: true
228+
// - name: tag
229+
// in: path
230+
// description: name of tag to delete
231+
// type: string
232+
// required: true
233+
// responses:
234+
// "204":
235+
// "$ref": "#/responses/empty"
236+
// "404":
237+
// "$ref": "#/responses/notFound"
238+
// "409":
239+
// "$ref": "#/responses/conflict"
240+
241+
tag, err := models.GetRelease(ctx.Repo.Repository.ID, ctx.Params("tag"))
242+
if err != nil {
243+
if models.IsErrReleaseNotExist(err) {
244+
ctx.NotFound()
245+
return
246+
}
247+
ctx.Error(http.StatusInternalServerError, "GetRelease", err)
248+
return
249+
}
250+
251+
if !tag.IsTag {
252+
ctx.Error(http.StatusConflict, "IsTag", errors.New("a tag attached to a release cannot be deleted directly"))
253+
return
254+
}
255+
256+
if err = releaseservice.DeleteReleaseByID(tag.ID, ctx.User, true); err != nil {
257+
ctx.Error(http.StatusInternalServerError, "DeleteReleaseByID", err)
258+
}
259+
260+
ctx.Status(http.StatusNoContent)
261+
}

‎templates/swagger/v1_json.tmpl‎

Lines changed: 42 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3657,7 +3657,7 @@
36573657
"repository"
36583658
],
36593659
"summary": "Gets the tag object of an annotated tag (not lightweight tags)",
3660-
"operationId": "GetTag",
3660+
"operationId": "GetAnnotatedTag",
36613661
"parameters": [
36623662
{
36633663
"type": "string",
@@ -9129,6 +9129,47 @@
91299129
}
91309130
},
91319131
"/repos/{owner}/{repo}/tags/{tag}": {
9132+
"get": {
9133+
"produces": [
9134+
"application/json"
9135+
],
9136+
"tags": [
9137+
"repository"
9138+
],
9139+
"summary": "Get the tag of a repository by tag name",
9140+
"operationId": "repoGetTag",
9141+
"parameters": [
9142+
{
9143+
"type": "string",
9144+
"description": "owner of the repo",
9145+
"name": "owner",
9146+
"in": "path",
9147+
"required": true
9148+
},
9149+
{
9150+
"type": "string",
9151+
"description": "name of the repo",
9152+
"name": "repo",
9153+
"in": "path",
9154+
"required": true
9155+
},
9156+
{
9157+
"type": "string",
9158+
"description": "name of tag",
9159+
"name": "tag",
9160+
"in": "path",
9161+
"required": true
9162+
}
9163+
],
9164+
"responses": {
9165+
"200": {
9166+
"$ref": "#/responses/empty"
9167+
},
9168+
"404": {
9169+
"$ref": "#/responses/notFound"
9170+
}
9171+
}
9172+
},
91329173
"delete": {
91339174
"produces": [
91349175
"application/json"

0 commit comments

Comments
 (0)