Merge pull request #684 from github/test-decimal

Fixed DECIMAL datatype

Author: Shlomi Noach

go/binlog/gomysql_reader.go

@@ -40,12 +40,13 @@ func NewGoMySQLReader(migrationContext *base.MigrationContext) (binlogReader *Go
 	serverId := uint32(migrationContext.ReplicaServerId)
 
 	binlogSyncerConfig := replication.BinlogSyncerConfig{
-		ServerID: serverId,
-		Flavor:   "mysql",
-		Host:     binlogReader.connectionConfig.Key.Hostname,
-		Port:     uint16(binlogReader.connectionConfig.Key.Port),
-		User:     binlogReader.connectionConfig.User,
-		Password: binlogReader.connectionConfig.Password,
+		ServerID:   serverId,
+		Flavor:     "mysql",
+		Host:       binlogReader.connectionConfig.Key.Hostname,
+		Port:       uint16(binlogReader.connectionConfig.Key.Port),
+		User:       binlogReader.connectionConfig.User,
+		Password:   binlogReader.connectionConfig.Password,
+		UseDecimal: true,
 	}
 	binlogReader.binlogSyncer = replication.NewBinlogSyncer(binlogSyncerConfig)
 

localtests/decimal/create.sql

@@ -0,0 +1,23 @@
+drop table if exists gh_ost_test;
+create table gh_ost_test (
+  id int auto_increment,
+  dec0 decimal(65,30) unsigned NOT NULL DEFAULT '0.000000000000000000000000000000',
+  dec1 decimal(65,30) unsigned NOT NULL DEFAULT '1.000000000000000000000000000000',
+  primary key(id)
+) auto_increment=1;
+
+drop event if exists gh_ost_test;
+delimiter ;;
+create event gh_ost_test
+  on schedule every 1 second
+  starts current_timestamp
+  ends current_timestamp + interval 60 second
+  on completion not preserve
+  enable
+  do
+begin
+  insert into gh_ost_test values (null, 0.0, 0.0);
+  insert into gh_ost_test values (null, 2.0, 4.0);
+  insert into gh_ost_test values (null, 99999999999999999999999999999999999.000, 6.0);
+  update gh_ost_test set dec1=4.5 where dec2=4.0 order by id desc limit 1;
+end ;;