Skip to content

Commit ad3f828

Browse files
CBID2nguyenalex836
andauthored
Clarifying that X-GitHub-Delivery is unique per event, not per delivery (#33184)
Co-authored-by: Alex Nguyen <[email protected]>
1 parent c2d169f commit ad3f828

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

content/webhooks/using-webhooks/best-practices-for-using-webhooks.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ If your server goes down, you should redeliver missed webhooks once your server
5252

5353
## Use the `X-GitHub-Delivery` header
5454

55-
In a replay attack, a bad actor intercepts a webhook delivery and re-sends the delivery. To protect against replay attacks, you can use the `X-GitHub-Delivery` header to ensure that each delivery is unique.
55+
In a replay attack, a bad actor intercepts a webhook delivery and re-sends the delivery. To protect against replay attacks, you can use the `X-GitHub-Delivery` header to ensure that each delivery is unique per event.
5656

5757
{% note %}
5858

content/webhooks/webhook-events-and-payloads.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ HTTP POST payloads that are delivered to your webhook's configured URL endpoint
3737

3838
- `X-GitHub-Hook-ID`: The unique identifier of the webhook.
3939
- `X-GitHub-Event`: The name of the event that triggered the delivery.
40-
- `X-GitHub-Delivery`: A globally unique identifier (GUID) to identify the delivery.{% ifversion ghes %}
40+
- `X-GitHub-Delivery`: A globally unique identifier (GUID) to identify the event.{% ifversion ghes %}
4141
- `X-GitHub-Enterprise-Version`: The version of the {% data variables.product.prodname_ghe_server %} instance that sent the HTTP POST payload.
4242
- `X-GitHub-Enterprise-Host`: The hostname of the {% data variables.product.prodname_ghe_server %} instance that sent the HTTP POST payload.{% endif %}
4343
- `X-Hub-Signature`: This header is sent if the webhook is configured with a `secret`. This is the HMAC hex digest of the request body, and is generated using the SHA-1 hash function and the `secret` as the HMAC `key`. `X-Hub-Signature` is provided for compatibility with existing integrations. We recommend that you use the more secure `X-Hub-Signature-256` instead.

0 commit comments

Comments
 (0)