Skip to content

Commit 7bdfa97

Browse files
authored
Merge pull request #3184 from github/nickrolfe/go-overlay
Overlays: allow any build mode for Go
2 parents 8a6b62b + 7892cb2 commit 7bdfa97

File tree

2 files changed

+15
-2
lines changed

2 files changed

+15
-2
lines changed

lib/init-action.js

Lines changed: 7 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/config-utils.ts

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -723,7 +723,14 @@ export async function getOverlayDatabaseMode(
723723
buildMode !== BuildMode.None &&
724724
(
725725
await Promise.all(
726-
languages.map(async (l) => await codeql.isTracedLanguage(l)),
726+
languages.map(
727+
async (l) =>
728+
l !== KnownLanguage.go && // Workaround to allow overlay analysis for Go with any build
729+
// mode, since it does not yet support BMN. The Go autobuilder and/or extractor will
730+
// ensure that overlay-base databases are only created for supported Go build setups,
731+
// and that we'll fall back to full databases in other cases.
732+
(await codeql.isTracedLanguage(l)),
733+
),
727734
)
728735
).some(Boolean)
729736
) {

0 commit comments

Comments
 (0)