feat(routing): removed unused code

Signed-off-by: Fredi Raspall <[email protected]>

Author: Fredi-raspall

routing/src/display.rs

@@ -2,12 +2,20 @@
 // Copyright Open Network Fabric Authors
 
 //! Module that implements Display for routing objects
-
+//!
+//! Note: most of the objects for which Display is implemented here belong to
+//! the routing database which is fully and only owned by the routing thread.
+//! This includes the Fib contents since fibs belong to vrfs.
+//! So:
+///    - it is Okay to call any of this from the routing thread (cli)
+///    - other threads may not be able to call Display's for routing objects.
+///    - Display for Fib objects visible from dataplane workers can be safely called.
+///    - Cli thread does not need a read handle cache to inspect Fib contents
+///    - Still, FIXME(fredi): make that distinction clearer
 use crate::atable::adjacency::{Adjacency, AdjacencyTable};
 use crate::cpi::{CpiStats, CpiStatus, StatsRow};
 use crate::fib::fibgroupstore::FibRoute;
 use crate::fib::fibobjects::{EgressObject, FibEntry, FibGroup, PktInstruction};
-use crate::fib::fibtable::FibTable;
 use crate::fib::fibtype::{Fib, FibKey};
 use crate::frr::frrmi::{FrrAppliedConfig, Frrmi, FrrmiStats};
 
@@ -723,22 +731,6 @@ impl Display for Fib {
         Ok(())
     }
 }
-impl Display for FibTable {
-    fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> Result<(), std::fmt::Error> {
-        Heading(format!(
-            " Fib Table ({} fibs, version: {})",
-            self.len(),
-            self.version()
-        ))
-        .fmt(f)?;
-        for fibr in self.values().map(|f| f.handle()) {
-            if let Some(fib) = fibr.enter() {
-                write!(f, "{}", *fib)?;
-            }
-        }
-        Ok(())
-    }
-}
 
 pub struct FibViewV4<'a, F>
 where

routing/src/fib/fibtable.rs

@@ -78,24 +78,12 @@ impl FibTable {
         self.get_entry(key).map(|entry| entry.factory.handle())
     }
 
+    /// Number of entries in this table
     #[must_use]
+    #[cfg(test)]
     pub(crate) fn len(&self) -> usize {
         self.entries.len()
     }
-    /// Tell if fib table is empty
-    #[must_use]
-    #[allow(unused)]
-    pub(crate) fn is_empty(&self) -> bool {
-        self.entries.is_empty()
-    }
-    /// Provide an iterator of [`FibReaderFactory`]s
-    pub(crate) fn values(&self) -> impl Iterator<Item = &FibReaderFactory> {
-        self.entries.values().map(|e| &e.factory)
-    }
-    /// Tell version of this [`FibTable`]
-    pub(crate) fn version(&self) -> u64 {
-        self.version
-    }
 }
 
 enum FibTableChange {