Don't offer disabled transport methods under preferences

[gitblit]

Originally reported on Google Code with ID 518

Thanks for another solid update, running 1.6.1 already!

Now I'd like to ask for a rather cosmetic change. The "Transport Preference" setting
under "preferences" of the user page offers all 4 transport options regardless of git.acceptedPushTransports.
I'm pretty Gitblit falls back to the correct option under the hood, but it's rather
confusing nevertheless so it'd be handy to only show the methods that are actually
enabled.

Reported by sundayfunday1234@outlook.com on 2014-10-24 01:50:41

[gitblit]

Reported by James.Moger on 2014-10-24 12:03:29

• Status changed: Accepted
• Labels added: Milestone-1.7.0

[gitblit]

Actually, it already excludes disabled transports BUT it does not consider accepted
PUSH transports.

I'm confident there are many installations where a user may only have clone access
to Gitblit and by only considering accepted PUSH transports this would handicap their
experience and generate complaints.

Reported by James.Moger on 2014-10-31 13:30:36

• Status changed: WontFix

[gitblit]

I can't confirm that either. I have server.httpsPort = 0 yet it offers 4 transport methods
(GIT, HTTP, HTTPS, SSH) on the GUI, and actually only 2 of them works for cloning (GIT,
HTTP). The other 2 won't even affect the repository url when re-opening a repo page.

Reported by sundayfunday1234@outlook.com on 2014-10-31 13:59:14

[gitblit]

Ah.  I'm looking at the 1.7.0 code, not 1.6.x.  That will only show enabled transports
except...

http/https is tricky because of the GO/WAR split & reverse proxies.  That would require
a new setting to handle WAR and/or reverse proxies.

Reported by James.Moger on 2014-10-31 14:20:34

[gitblit]

Oh I see, thanks for the explanation :)

Reported by sundayfunday1234@outlook.com on 2014-10-31 14:29:48

[gitblit]

I pushed an improvement for GO.  I'm going to sit on WAR.

Reported by James.Moger on 2014-10-31 14:38:32

[gitblit]

Nice!

Reported by sundayfunday1234@outlook.com on 2014-10-31 14:49:21