fix: Desktop symbol upload (#2029)

Author: bitsandfoxes

src/Sentry.Unity.Editor/Native/BuildPostProcess.cs

@@ -25,51 +25,55 @@ public static void OnPostProcessBuild(BuildTarget target, string executablePath)
 
         var (options, cliOptions) = SentryScriptableObject.ConfiguredBuildTimeOptions();
         var logger = options?.DiagnosticLogger ?? new UnityLogger(options ?? new SentryUnityOptions());
+
+        if (options is null)
+        {
+            logger.LogWarning("Native support disabled because Sentry has not been configured. " +
+                              "You can do that through the editor: {0}", SentryWindow.EditorMenuPath);
+            return;
+        }
+
+        if (!options.IsValid())
+        {
+            logger.LogDebug("Skipping native post build process.");
+            return;
+        }
+
 #pragma warning disable CS0618
         var isMono = PlayerSettings.GetScriptingBackend(targetGroup) == ScriptingImplementation.Mono2x;
 #pragma warning restore CS0618
 
-        var buildOutputDir = Path.GetDirectoryName(executablePath);
         var executableName = Path.GetFileName(executablePath);
-
-        try
+        var buildOutputDir = Path.GetDirectoryName(executablePath);
+        if (string.IsNullOrEmpty(buildOutputDir))
         {
-            if (options is null)
-            {
-                logger.LogWarning("Native support disabled because Sentry has not been configured. " +
-                                  "You can do that through the editor: {0}", SentryWindow.EditorMenuPath);
-                return;
-            }
-
-            if (!options.IsValid())
-            {
-                logger.LogDebug("Native support disabled.");
-                return;
-            }
+            logger.LogError("Failed to find build output directory based on the executable path '{0}'." +
+                            "\nSkipping adding crash-handler and uploading debug symbols.", executablePath);
+            return;
+        }
 
-            if (!IsEnabledForPlatform(target, options))
-            {
-                logger.LogDebug("Native support for the current platform is disabled in the configuration.");
-                return;
-            }
+        UploadDebugSymbols(logger, target, buildOutputDir, executableName, options, cliOptions, isMono);
 
-            logger.LogDebug("Adding native support.");
+        if (!IsEnabledForPlatform(target, options))
+        {
+            logger.LogDebug("Skipping adding the crash-handler. Native support for the current platform is disabled in the configuration.");
+            return;
+        }
 
+        try
+        {
             AddCrashHandler(logger, target, buildOutputDir, executableName);
         }
         catch (Exception e)
         {
-            logger.LogError(e, "Failed to add the Sentry native integration to the built application");
+            logger.LogError(e, "Failed to add the crash-handler to the built application.");
             throw new BuildFailedException("Sentry Native BuildPostProcess failed");
         }
-        finally
-        {
-            UploadDebugSymbols(logger, target, buildOutputDir, executableName, options, cliOptions, isMono);
-        }
     }
 
     private static bool IsEnabledForPlatform(BuildTarget target, SentryUnityOptions options) => target switch
     {
+        BuildTarget.StandaloneWindows => options.WindowsNativeSupportEnabled,
         BuildTarget.StandaloneWindows64 => options.WindowsNativeSupportEnabled,
         BuildTarget.StandaloneOSX => options.MacosNativeSupportEnabled,
         BuildTarget.StandaloneLinux64 => options.LinuxNativeSupportEnabled,
@@ -80,7 +84,9 @@ private static void AddCrashHandler(IDiagnosticLogger logger, BuildTarget target
     {
         switch (target)
         {
+            case BuildTarget.StandaloneWindows:
             case BuildTarget.StandaloneWindows64:
+                logger.LogDebug("Adding crashpad.");
                 CopyHandler(logger, buildOutputDir, Path.Combine("Windows", "Sentry", "crashpad_handler.exe"));
                 CopyHandler(logger, buildOutputDir, Path.Combine("Windows", "Sentry", "crashpad_wer.dll"));
                 break;
@@ -197,7 +203,7 @@ private static void UploadDebugSymbols(IDiagnosticLogger logger, BuildTarget tar
                 addPath(Path.GetFullPath($"Packages/{SentryPackageInfo.GetName()}/Plugins/macOS/Sentry/Sentry.dylib.dSYM"));
 
                 if (isMono)
-                { 
+                {
                     addFilesMatching(buildOutputDir, new[] { "*.pdb" });
 
                     // Unity stores the .pdb files in './Library/ScriptAssemblies/' and starting with 2020 in