Review fixes

Author: sl0thentr0py

sentry_sdk/_log_batcher.py

@@ -24,7 +24,7 @@ def __init__(self, capture_func: Callable[[Envelope], None]) -> None:
         self._running = True
         self._lock = threading.Lock()
 
-        self._flush_event: threading.Event = threading.Event()
+        self._flush_event = threading.Event()
 
         self._flusher: Optional[threading.Thread] = None
         self._flusher_pid: Optional[int] = None

sentry_sdk/_queue.py

@@ -76,7 +76,10 @@
 from collections import deque
 from time import time
 
-from typing import Any
+from typing import TYPE_CHECKING
+
+if TYPE_CHECKING:
+    from typing import Any
 
 
 __all__ = ["EmptyError", "FullError", "Queue"]

sentry_sdk/client.py

@@ -75,7 +75,7 @@
 _client_init_debug = ContextVar("client_init_debug")
 
 
-SDK_INFO: "SDKInfo" = {
+SDK_INFO: SDKInfo = {
     "name": "sentry.python",  # SDK name will be overridden after integrations have been loaded with sentry_sdk.integrations.setup_integrations()
     "version": VERSION,
     "packages": [{"name": "pypi:sentry-sdk", "version": VERSION}],
@@ -464,7 +464,7 @@ def _prepare_event(
                         )
                 return None
 
-            event = event_  # Updated event from scope
+            event = event_
             spans_delta = spans_before - len(
                 cast("List[Dict[str, object]]", event.get("spans", []))
             )
@@ -578,7 +578,7 @@ def _prepare_event(
                 if event.get("exception"):
                     DedupeIntegration.reset_last_seen()
 
-            event = new_event  # Updated event from before_send
+            event = new_event
 
         before_send_transaction = self.options["before_send_transaction"]
         if (
@@ -610,7 +610,7 @@ def _prepare_event(
                         reason="before_send", data_category="span", quantity=spans_delta
                     )
 
-            event = new_event  # Updated event from before_send_transaction
+            event = new_event
 
         return event
 
@@ -757,17 +757,17 @@ def capture_event(
 
         :returns: An event ID. May be `None` if there is no DSN set or of if the SDK decided to discard the event for other reasons. In such situations setting `debug=True` on `init()` may help.
         """
-        hint_dict: Hint = dict(hint or ())
+        hint: Hint = dict(hint or ())
 
-        if not self._should_capture(event, hint_dict, scope):
+        if not self._should_capture(event, hint, scope):
             return None
 
         profile = event.pop("profile", None)
 
         event_id = event.get("event_id")
         if event_id is None:
             event["event_id"] = event_id = uuid.uuid4().hex
-        event_opt = self._prepare_event(event, hint_dict, scope)
+        event_opt = self._prepare_event(event, hint, scope)
         if event_opt is None:
             return None
 
@@ -783,11 +783,11 @@ def capture_event(
         if (
             not is_transaction
             and not is_checkin
-            and not self._should_sample_error(event, hint_dict)
+            and not self._should_sample_error(event, hint)
         ):
             return None
 
-        attachments = hint_dict.get("attachments")
+        attachments = hint.get("attachments")
 
         trace_context = event_opt.get("contexts", {}).get("trace") or {}
         dynamic_sampling_context = trace_context.pop("dynamic_sampling_context", {})