Skip to content

ref(logs): extract attribute compilation logic in Monolog LogsHandler #1929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

ref(logs): extract attribute compilation logic in Monolog LogsHandler #1929

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2443c56
ref(logs): extract attribute compilation logic in Monolog LogsHandler
huangdijia Sep 29, 2025
c6a3be9
ref(logs): update compileAttributes method to accept both array and L…
huangdijia Sep 29, 2025
1790af4
Merge branch 'master' into refactor/monolog-handler-extract-attribute…
cleptric Sep 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/Monolog/LogsHandler.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ public function handle($record): bool
self::getSentryLogLevelFromMonologLevel($record['level']),
$record['message'],
[],
array_merge($record['context'], $record['extra'], ['sentry.origin' => 'auto.logger.monolog'])
$this->compileAttributes($record)
);

return $this->bubble === false;
Expand Down Expand Up @@ -123,4 +123,12 @@ public function __destruct()
// Just in case so that the destructor can never fail.
}
}

/**
* @param array<string, mixed>|LogRecord $record
*/
protected function compileAttributes($record): array
{
return array_merge($record['context'], $record['extra'], ['sentry.origin' => 'auto.logger.monolog']);
}
}