Skip to content

Commit b238c29

Browse files
runningcodeclaude
andcommitted
Fix versionCode truncation on Android API 28+
Change versionCode from Int to Long in UpdateCheckParams to prevent silent truncation of large version codes when using packageInfo.longVersionCode. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
1 parent 0cae425 commit b238c29

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

sentry-android-distribution/src/main/java/io/sentry/android/distribution/DistributionHttpClient.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ internal class DistributionHttpClient(private val options: SentryOptions) {
2424
val mainBinaryIdentifier: String,
2525
val appId: String,
2626
val platform: String = "android",
27-
val versionCode: Int,
27+
val versionCode: Long,
2828
val versionName: String,
2929
)
3030

sentry-android-distribution/src/main/java/io/sentry/android/distribution/DistributionIntegration.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -126,9 +126,9 @@ public class DistributionIntegration(context: Context) : Integration, IDistribut
126126
val versionName = packageInfo.versionName ?: "unknown"
127127
val versionCode =
128128
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.P) {
129-
packageInfo.longVersionCode.toInt()
129+
packageInfo.longVersionCode
130130
} else {
131-
@Suppress("DEPRECATION") packageInfo.versionCode
131+
@Suppress("DEPRECATION") packageInfo.versionCode.toLong()
132132
}
133133
val appId = context.applicationInfo.packageName
134134

sentry-android-distribution/src/test/java/io/sentry/android/distribution/DistributionHttpClientTest.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ class DistributionHttpClientTest {
3737
mainBinaryIdentifier = "com.emergetools.hackernews",
3838
appId = "com.emergetools.hackernews",
3939
versionName = "1.0.0",
40-
versionCode = 5,
40+
versionCode = 5L,
4141
)
4242

4343
val response = httpClient.checkForUpdates(params)

0 commit comments

Comments
 (0)