From 2cf566379fe51b41854587e7a08a43548ca1822d Mon Sep 17 00:00:00 2001 From: James Crosswell Date: Tue, 26 Sep 2023 23:09:47 +1300 Subject: [PATCH 1/2] Removed ISpanContext --- src/Sentry/ISpanContext.cs | 10 ---------- src/Sentry/ISpanData.cs | 4 +++- src/Sentry/ITransactionContext.cs | 4 +++- src/Sentry/SpanContext.cs | 4 +++- 4 files changed, 9 insertions(+), 13 deletions(-) delete mode 100644 src/Sentry/ISpanContext.cs diff --git a/src/Sentry/ISpanContext.cs b/src/Sentry/ISpanContext.cs deleted file mode 100644 index 9ba75a0669..0000000000 --- a/src/Sentry/ISpanContext.cs +++ /dev/null @@ -1,10 +0,0 @@ -using Sentry.Protocol; - -namespace Sentry; - -/// -/// Span metadata. -/// -public interface ISpanContext : ITraceContext -{ -} \ No newline at end of file diff --git a/src/Sentry/ISpanData.cs b/src/Sentry/ISpanData.cs index 2187513f83..0f4f8a526c 100644 --- a/src/Sentry/ISpanData.cs +++ b/src/Sentry/ISpanData.cs @@ -1,9 +1,11 @@ +using Sentry.Protocol; + namespace Sentry; /// /// Immutable data belonging to a span. /// -public interface ISpanData : ISpanContext, IHasTags, IHasExtra +public interface ISpanData : ITraceContext, IHasTags, IHasExtra { /// /// Start timestamp. diff --git a/src/Sentry/ITransactionContext.cs b/src/Sentry/ITransactionContext.cs index 43291ac6d8..afe54c9fa5 100644 --- a/src/Sentry/ITransactionContext.cs +++ b/src/Sentry/ITransactionContext.cs @@ -1,9 +1,11 @@ +using Sentry.Protocol; + namespace Sentry; /// /// Transaction metadata. /// -public interface ITransactionContext : ISpanContext +public interface ITransactionContext : ITraceContext { /// /// Transaction name. diff --git a/src/Sentry/SpanContext.cs b/src/Sentry/SpanContext.cs index f55bc1521a..176dab1923 100644 --- a/src/Sentry/SpanContext.cs +++ b/src/Sentry/SpanContext.cs @@ -1,9 +1,11 @@ +using Sentry.Protocol; + namespace Sentry; /// /// Span metadata used for sampling. /// -public class SpanContext : ISpanContext +public class SpanContext : ITraceContext { /// public SpanId SpanId { get; } From 2300e025e5755c91777b8a5529a9ba7b30693c6f Mon Sep 17 00:00:00 2001 From: James Crosswell Date: Tue, 26 Sep 2023 23:21:28 +1300 Subject: [PATCH 2/2] Update CHANGELOG.md --- CHANGELOG.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index d2e69a5920..358a5b781d 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -14,6 +14,10 @@ without native/platform specific bindings and SDKs. See [this ticket for more de - Drop .NET 6 Mobile in favor of .NET 7 ([#2624](https://github.com/getsentry/sentry-dotnet/pull/2604)) +API Changes: + +- Removed ISpanContext ([#2668](https://github.com/getsentry/sentry-dotnet/pull/2668)) + ### Features - Sentry tracing middleware now gets configured automatically ([#2602](https://github.com/getsentry/sentry-dotnet/pull/2602))