From 69b34c1bc8ea04b06667a8fb3362fa3e61aa9c74 Mon Sep 17 00:00:00 2001 From: Sebastian Zivota Date: Fri, 8 Aug 2025 17:16:59 +0200 Subject: [PATCH 1/4] feat(danger): Allow skipping changelog with label This allows skipping the danger changelog check with a `skip-changelog` label in addition to `#skip-changelog` in the PR description. To make sure this triggers properly, the `danger` workflow should be run on a PR being `labeled` and `unlabeled`. --- danger/dangerfile.js | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/danger/dangerfile.js b/danger/dangerfile.js index 17a4b70..87f2bfa 100644 --- a/danger/dangerfile.js +++ b/danger/dangerfile.js @@ -69,7 +69,8 @@ async function checkChangelog() { // Check if skipped if ( ["ci", "test", "deps", "chore(deps)", "build(deps)"].includes(prFlavor) || - (danger.github.pr.body + "").includes("#skip-changelog") + (danger.github.pr.body + "").includes("#skip-changelog") || + (pr.labels || []).some(label => label.name === 'skip-changelog') ) { return; } @@ -126,7 +127,7 @@ Example: - ${prTitleFormatted} ([#${danger.github.pr.number}](${danger.github.pr.html_url})) \`\`\` -If none of the above apply, you can opt out of this check by adding \`#skip-changelog\` to the PR description.`.trim(), +If none of the above apply, you can opt out of this check by adding \`#skip-changelog\` to the PR description or adding a \`skip-changelog\` label.`.trim(), changelogFile ); } From ac1e0ae97a280c5fa68c9556904bca36fc9e06b3 Mon Sep 17 00:00:00 2001 From: Sebastian Zivota Date: Fri, 8 Aug 2025 17:23:58 +0200 Subject: [PATCH 2/4] Fix pr reference --- danger/dangerfile.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/danger/dangerfile.js b/danger/dangerfile.js index 87f2bfa..6855f24 100644 --- a/danger/dangerfile.js +++ b/danger/dangerfile.js @@ -70,7 +70,7 @@ async function checkChangelog() { if ( ["ci", "test", "deps", "chore(deps)", "build(deps)"].includes(prFlavor) || (danger.github.pr.body + "").includes("#skip-changelog") || - (pr.labels || []).some(label => label.name === 'skip-changelog') + (danger.github.pr.labels || []).some(label => label.name === 'skip-changelog') ) { return; } From ff6c8ffe0016d63bca70f22cfa80ea94076013f0 Mon Sep 17 00:00:00 2001 From: Sebastian Zivota Date: Fri, 8 Aug 2025 18:53:56 +0200 Subject: [PATCH 3/4] changelog --- CHANGELOG.md | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 4615133..94e5bf8 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,11 @@ # Changelog +## Unreleased + +### Features + +- Danger - Changelog checks can now additionally be skipped with a `skip-changelog` label ([#94](https://github.com/getsentry/github-workflows/pull/94)) + ## 2.12.0 ### Features From 5dd62ec6303a94403caeca895af93b0279289c2c Mon Sep 17 00:00:00 2001 From: Ivan Dlugos <6349682+vaind@users.noreply.github.com> Date: Fri, 8 Aug 2025 18:58:05 +0200 Subject: [PATCH 4/4] Update CHANGELOG.md --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 94e5bf8..81e0c34 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,6 +1,6 @@ # Changelog -## Unreleased +## 2.13.0 ### Features