fix(valid-types): re-allow namepaths in name-definers like typedef in non-typescript mode; fixes #1557

Author: brettz9

docs/rules/valid-types.md

@@ -243,7 +243,7 @@ function quux() {
 /**
  * @typedef {string} module:abc/def
  */
-// Settings: {"jsdoc":{"mode":"permissive"}}
+// Settings: {"jsdoc":{"mode":"typescript"}}
 // Message: Syntax error in name: module:abc/def
 
 /**
@@ -983,5 +983,10 @@ class Test {
    */
   method() { return this; }
 }
+
+/**
+ * @typedef {Object} module:src/core/Player~mediaFormat
+ */
+// Settings: {"jsdoc":{"mode":"jsdoc"}}
 ````
 

src/rules/validTypes.js

@@ -101,12 +101,12 @@ const tryParsePathIgnoreError = (path, mode) => {
 
 /**
  * @param {string} name
- * @param {import('jsdoc-type-pratt-parser').ParseMode|"permissive"} mode
+ * @param {import('jsdoc-type-pratt-parser').ParseMode} mode
  * @returns {boolean}
  */
 const tryParseNameIgnoreError = (name, mode) => {
   try {
-    parseName(name, mode === 'permissive' ? 'jsdoc' : mode);
+    parseName(name, mode);
 
     return true;
   } catch {
@@ -396,8 +396,14 @@ export default iterateJsdoc(({
 
     const hasNamePosition = utils.tagMightHaveName(tag.tag) &&
       Boolean(tag.name);
-    if (hasNamePosition && !tryParseNameIgnoreError(tag.name, mode)) {
+    if (
+      hasNamePosition &&
+      mode === 'typescript' &&
+      !tryParseNameIgnoreError(tag.name, mode)
+    ) {
       report(`Syntax error in name: ${tag.name}`, null, tag);
+    } else if (hasNamePosition && mode !== 'typescript') {
+      validNamepathParsing(tag.name, tag.tag);
     }
 
     for (const inlineTag of tag.inlineTags) {

test/rules/assertions/validTypes.js

@@ -264,7 +264,7 @@ export default /** @type {import('../index.js').TestCases} */ ({
       ],
       settings: {
         jsdoc: {
-          mode: 'permissive',
+          mode: 'typescript',
         },
       },
     },
@@ -2018,5 +2018,17 @@ export default /** @type {import('../index.js').TestCases} */ ({
         }
       `,
     },
+    {
+      code: `
+        /**
+         * @typedef {Object} module:src/core/Player~mediaFormat
+         */
+      `,
+      settings: {
+        jsdoc: {
+          mode: 'jsdoc',
+        },
+      },
+    },
   ],
 });