cppcheck fails #60

ChristopherPisz · 2022-06-30T14:40:42Z

ChristopherPisz
Jun 30, 2022

I am rather bad at cmake and unix in general. Trying cmake-init to make a consumable library. I am currently getting the following output from clion when using the dev preset.

====================[ Build | gussm_gussm | dev ]=============================== /snap/clion/193/bin/cmake/linux/bin/cmake --build --target gussm_gussm --preset dev [ 50%] Building CXX object CMakeFiles/gussm_gussm.dir/source/gussm.cpp.o Error running 'cppcheck': make[3]: *** [CMakeFiles/gussm_gussm.dir/build.make:76: CMakeFiles/gussm_gussm.dir/source/gussm.cpp.o] Error 1 make[2]: *** [CMakeFiles/Makefile2:133: CMakeFiles/gussm_gussm.dir/all] Error 2 make[1]: *** [CMakeFiles/Makefile2:140: CMakeFiles/gussm_gussm.dir/rule] Error 2 make: *** [Makefile:199: gussm_gussm] Error 2

No information is given as to what the error is. What to do?

ChristopherPisz · 2022-06-30T14:53:27Z

ChristopherPisz
Jun 30, 2022
Author

I had to install and update it evidently. I am pretty sure my build machine doesn't have this. How can I take out the cpp check step from dev profile in cmakepresets.json?

3 replies

friendlyanon Jun 30, 2022
Maintainer

In the generated CMakeUserPresets.json file you can modify what presets dev-common inherits from. cppcheck and clang-tidy enable the respective tool integrations.

As an aside, I have also noticed that the developer guide (HACKING.md) doesn't mention these presets as something to be inherited from, but it should.

ChristopherPisz Jul 1, 2022
Author

If I understand the file correctly, and I probably don't, I don't see a dev-common. I only see a "dev-mode" which inherits from "cmake-pendantic", which in turn does not have an inheritance line. cmake-pendantic does however have many "warnings" bools.

friendlyanon Jul 1, 2022
Maintainer

CMakePresets.json is not CMakeUserPresets.json. The latter is ignored by git and that's where dev and dev-common live.

friendlyanon · 2022-06-30T15:20:22Z

friendlyanon
Jun 30, 2022
Maintainer

Yes, by default tools like cppcheck and clang-tidy have integrations enabled that automatically run on build. This requires them to be installed of course.

You can disable these tools for the dev preset by either saying so when prompted or by using the --no-cppcheck and --no-clang-tidy flags in non-interactive mode.

4 replies

ClausKlein Aug 22, 2023

Why is cppcheck default enabled together with clang-tidy.

IMHO: clang-tidy woud be enaugh, or not?

friendlyanon Aug 22, 2023
Maintainer

Based on what I read at the time there seemed to be little overlap and it never hurts to get more coverage.

ClausKlein Aug 23, 2023

But the price is the developer time.

bash-3.2$ cmake . -DENABLE_CPPCHECK=YES
-- Repository already exists at /Users/clausklein/vcpkg.
-- Running vcpkg install
Detecting compiler hash for triplet x64-osx...
All requested packages are currently installed.
Restored 0 package(s) from /Users/clausklein/.cache/vcpkg/archives in 21.9 us. Use --debug to see more details.
Total install time: 159 us
The package fmt provides CMake targets:

    find_package(fmt CONFIG REQUIRED)
    target_link_libraries(main PRIVATE fmt::fmt)

    # Or use the header-only version
    find_package(fmt CONFIG REQUIRED)
    target_link_libraries(main PRIVATE fmt::fmt-header-only)

catch2 provides CMake targets:

    # this is heuristically generated, and may not be correct
    find_package(Catch2 CONFIG REQUIRED)
    target_link_libraries(main PRIVATE Catch2::Catch2 Catch2::Catch2WithMain)

-- Running vcpkg install - done
-- The default CMAKE_CXX_STANDARD used by external targets and tools is not set yet. Using the latest supported C++ standard that is 20
-- The default CMAKE_C_STANDARD used by external targets and tools is not set yet. Using the latest supported C standard that is 17
-- /usr/local/bin/ccache found and enabled
-- Configuring done (4.6s)
-- Generating done (0.1s)
-- Build files have been written to: /Users/clausklein/Workspace/cpp/cpp_vcpkg_project/build/debug
bash-3.2$ time ninja
[1/18] Building CXX object my_exe/CMakeFiles/my_exe.dir/Debug/src/main.cpp.o
Checking /Users/clausklein/Workspace/cpp/cpp_vcpkg_project/my_exe/src/main.cpp ...
Checking /Users/clausklein/Workspace/cpp/cpp_vcpkg_project/my_exe/src/main.cpp: CMAKE_INTDIR="Debug"...
[2/18] Building CXX object my_lib/CMakeFiles/my_lib.dir/Debug/src/my_lib/lib.cpp.o
Checking /Users/clausklein/Workspace/cpp/cpp_vcpkg_project/my_lib/src/my_lib/lib.cpp ...
Checking /Users/clausklein/Workspace/cpp/cpp_vcpkg_project/my_lib/src/my_lib/lib.cpp: CMAKE_INTDIR="Debug"...
[5/18] Building CXX object my_lib/test/constexpr/CMakeFiles/my_lib_relaxed_constexpr_tests.dir/Debug/constexpr_tests.cpp.o
Checking /Users/clausklein/Workspace/cpp/cpp_vcpkg_project/my_lib/test/constexpr/constexpr_tests.cpp ...
Checking /Users/clausklein/Workspace/cpp/cpp_vcpkg_project/my_lib/test/constexpr/constexpr_tests.cpp: CATCH_CONFIG_MAIN=1;CATCH_CONFIG_RUNTIME_STATIC_REQUIRE=1;DO_NOT_USE_WMAIN=1;CMAKE_INTDIR="Debug"...
[6/18] Building CXX object my_lib/test/CMakeFiles/my_lib_tests.dir/Debug/tests.cpp.o
Checking /Users/clausklein/Workspace/cpp/cpp_vcpkg_project/my_lib/test/tests.cpp ...
Checking /Users/clausklein/Workspace/cpp/cpp_vcpkg_project/my_lib/test/tests.cpp: CATCH_CONFIG_MAIN=1;DO_NOT_USE_WMAIN=1;CMAKE_INTDIR="Debug"...
[7/18] Building CXX object my_lib/test/constexpr/CMakeFiles/my_lib_constexpr_tests.dir/Debug/constexpr_tests.cpp.o
Checking /Users/clausklein/Workspace/cpp/cpp_vcpkg_project/my_lib/test/constexpr/constexpr_tests.cpp ...
Checking /Users/clausklein/Workspace/cpp/cpp_vcpkg_project/my_lib/test/constexpr/constexpr_tests.cpp: CATCH_CONFIG_MAIN=1;DO_NOT_USE_WMAIN=1;CMAKE_INTDIR="Debug"...
[9/18] Building CXX object my_header_lib/test/constexpr/CMakeFiles/my_header_lib_relaxed_constexpr_tests.dir/Debug/constexpr_tests.cpp.o
Checking /Users/clausklein/Workspace/cpp/cpp_vcpkg_project/my_header_lib/test/constexpr/constexpr_tests.cpp ...
Checking /Users/clausklein/Workspace/cpp/cpp_vcpkg_project/my_header_lib/test/constexpr/constexpr_tests.cpp: CATCH_CONFIG_MAIN=1;CATCH_CONFIG_RUNTIME_STATIC_REQUIRE=1;DO_NOT_USE_WMAIN=1;CMAKE_INTDIR="Debug"...
[10/18] Building CXX object my_header_lib/test/constexpr/CMakeFiles/my_header_lib_constexpr_tests.dir/Debug/constexpr_tests.cpp.o
Checking /Users/clausklein/Workspace/cpp/cpp_vcpkg_project/my_header_lib/test/constexpr/constexpr_tests.cpp ...
Checking /Users/clausklein/Workspace/cpp/cpp_vcpkg_project/my_header_lib/test/constexpr/constexpr_tests.cpp: CATCH_CONFIG_MAIN=1;DO_NOT_USE_WMAIN=1;CMAKE_INTDIR="Debug"...
[13/18] Building CXX object my_exe/test/CMakeFiles/my_exe_lib_tests.dir/Debug/tests.cpp.o
Checking /Users/clausklein/Workspace/cpp/cpp_vcpkg_project/my_exe/test/tests.cpp ...
Checking /Users/clausklein/Workspace/cpp/cpp_vcpkg_project/my_exe/test/tests.cpp: CATCH_CONFIG_MAIN=1;DO_NOT_USE_WMAIN=1;CMAKE_INTDIR="Debug"...
[16/18] Building CXX object my_header_lib/test/CMakeFiles/my_header_lib_tests.dir/Debug/tests.cpp.o
Checking /Users/clausklein/Workspace/cpp/cpp_vcpkg_project/my_header_lib/test/tests.cpp ...
Checking /Users/clausklein/Workspace/cpp/cpp_vcpkg_project/my_header_lib/test/tests.cpp: CATCH_CONFIG_MAIN=1;DO_NOT_USE_WMAIN=1;CMAKE_INTDIR="Debug"...
[18/18] Linking CXX executable my_header_lib/test/Debug/my_header_lib_tests

real	1m2.679s
user	7m20.241s
sys	0m7.258s
bash-3.2$ cmake . -DENABLE_CPPCHECK=NO 
-- Repository already exists at /Users/clausklein/vcpkg.
-- Running vcpkg install
Detecting compiler hash for triplet x64-osx...
All requested packages are currently installed.
Restored 0 package(s) from /Users/clausklein/.cache/vcpkg/archives in 2.15 us. Use --debug to see more details.
Total install time: 16.1 us
The package fmt provides CMake targets:

    find_package(fmt CONFIG REQUIRED)
    target_link_libraries(main PRIVATE fmt::fmt)

    # Or use the header-only version
    find_package(fmt CONFIG REQUIRED)
    target_link_libraries(main PRIVATE fmt::fmt-header-only)

catch2 provides CMake targets:

    # this is heuristically generated, and may not be correct
    find_package(Catch2 CONFIG REQUIRED)
    target_link_libraries(main PRIVATE Catch2::Catch2 Catch2::Catch2WithMain)

-- Running vcpkg install - done
-- The default CMAKE_CXX_STANDARD used by external targets and tools is not set yet. Using the latest supported C++ standard that is 20
-- The default CMAKE_C_STANDARD used by external targets and tools is not set yet. Using the latest supported C standard that is 17
-- /usr/local/bin/ccache found and enabled
-- Configuring done (3.4s)
-- Generating done (0.0s)
-- Build files have been written to: /Users/clausklein/Workspace/cpp/cpp_vcpkg_project/build/debug
bash-3.2$ time ninja
[18/18] Linking CXX executable my_exe/test/Debug/my_exe_lib_tests

real	1m1.759s
user	7m22.174s
sys	0m6.985s
bash-3.2$ cmake . -DENABLE_CLANG_TIDY=NO 
-- Repository already exists at /Users/clausklein/vcpkg.
-- Running vcpkg install
Detecting compiler hash for triplet x64-osx...
All requested packages are currently installed.
Restored 0 package(s) from /Users/clausklein/.cache/vcpkg/archives in 2.17 us. Use --debug to see more details.
Total install time: 16.4 us
The package fmt provides CMake targets:

    find_package(fmt CONFIG REQUIRED)
    target_link_libraries(main PRIVATE fmt::fmt)

    # Or use the header-only version
    find_package(fmt CONFIG REQUIRED)
    target_link_libraries(main PRIVATE fmt::fmt-header-only)

catch2 provides CMake targets:

    # this is heuristically generated, and may not be correct
    find_package(Catch2 CONFIG REQUIRED)
    target_link_libraries(main PRIVATE Catch2::Catch2 Catch2::Catch2WithMain)

-- Running vcpkg install - done
-- The default CMAKE_CXX_STANDARD used by external targets and tools is not set yet. Using the latest supported C++ standard that is 20
-- The default CMAKE_C_STANDARD used by external targets and tools is not set yet. Using the latest supported C standard that is 17
-- /usr/local/bin/ccache found and enabled
-- Configuring done (3.4s)
-- Generating done (0.0s)
-- Build files have been written to: /Users/clausklein/Workspace/cpp/cpp_vcpkg_project/build/debug
bash-3.2$ time ninja
[18/18] Linking CXX executable my_lib/test/Debug/my_lib_tests

real	0m2.664s
user	0m4.757s
sys	0m1.773s
bash-3.2$

friendlyanon Aug 24, 2023
Maintainer

clang-tidy and cppcheck are optional. If you don't want to use them locally, just don't add them to your configure preset.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

cppcheck fails #60

Uh oh!

{{title}}

Uh oh!

Replies: 2 comments 7 replies

Uh oh!

{{title}}

Uh oh!

Uh oh!

{{title}}

Uh oh!

Uh oh!

{{title}}

Uh oh!

Uh oh!

{{title}}

Uh oh!

Uh oh!

{{title}}

Uh oh!

Uh oh!

{{title}}

Uh oh!

Uh oh!

{{title}}

Uh oh!

Uh oh!

{{title}}

Uh oh!

Uh oh!

{{title}}

Uh oh!

Select a reply

Uh oh!

cppcheck fails #60

Uh oh!

ChristopherPisz Jun 30, 2022

Replies: 2 comments · 7 replies

Uh oh!

ChristopherPisz Jun 30, 2022 Author

Uh oh!

friendlyanon Jun 30, 2022 Maintainer

Uh oh!

ChristopherPisz Jul 1, 2022 Author

Uh oh!

friendlyanon Jul 1, 2022 Maintainer

Uh oh!

friendlyanon Jun 30, 2022 Maintainer

Uh oh!

ClausKlein Aug 22, 2023

Uh oh!

friendlyanon Aug 22, 2023 Maintainer

Uh oh!

ClausKlein Aug 23, 2023

Uh oh!

friendlyanon Aug 24, 2023 Maintainer

ChristopherPisz
Jun 30, 2022

Replies: 2 comments 7 replies

ChristopherPisz
Jun 30, 2022
Author

friendlyanon Jun 30, 2022
Maintainer

ChristopherPisz Jul 1, 2022
Author

friendlyanon Jul 1, 2022
Maintainer

friendlyanon
Jun 30, 2022
Maintainer

friendlyanon Aug 22, 2023
Maintainer

friendlyanon Aug 24, 2023
Maintainer