Skip to content

Commit b208250

Browse files
committed
Revert "RISC-V: Enable -gvariable-location-views by default"
This reverts commit 76c2954.
1 parent 0e0b641 commit b208250

File tree

4 files changed

+8
-26
lines changed

4 files changed

+8
-26
lines changed

gcc/dwarf2out.cc

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -10372,10 +10372,8 @@ dwarf2out_maybe_output_loclist_view_pair (dw_loc_list_ref curr)
1037210372
}
1037310373
else
1037410374
{
10375-
dw2_asm_output_data_uleb128 (ZERO_VIEW_P (curr->vbegin)
10376-
? 0 : curr->vbegin, "Location view begin");
10377-
dw2_asm_output_data_uleb128 (ZERO_VIEW_P (curr->vend)
10378-
? 0 : curr->vend, "Location view end");
10375+
dw2_asm_output_data_uleb128 (curr->vbegin, "Location view begin");
10376+
dw2_asm_output_data_uleb128 (curr->vend, "Location view end");
1037910377
}
1038010378
#endif /* DW_LLE_view_pair */
1038110379

@@ -10438,12 +10436,10 @@ output_loc_list (dw_loc_list_ref list_head)
1043810436
}
1043910437
else
1044010438
{
10441-
dw2_asm_output_data_uleb128 (ZERO_VIEW_P (curr->vbegin)
10442-
? 0 : curr->vbegin,
10439+
dw2_asm_output_data_uleb128 (curr->vbegin,
1044310440
"View list begin (%s)",
1044410441
list_head->vl_symbol);
10445-
dw2_asm_output_data_uleb128 (ZERO_VIEW_P (curr->vend)
10446-
? 0 : curr->vend,
10442+
dw2_asm_output_data_uleb128 (curr->vend,
1044710443
"View list end (%s)",
1044810444
list_head->vl_symbol);
1044910445
}

gcc/testsuite/gcc.dg/debug/dwarf2/inline2.c

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -30,9 +30,6 @@
3030
layout. */
3131
/* { dg-final { scan-assembler-times "\\(DIE \\(\[^\n\]*\\) DW_TAG_lexical_block" 0 } } */
3232

33-
/* Each inline instance should have DW_AT_entry_pc and DW_AT_GNU_entry_view. */
34-
/* { dg-final { scan-assembler-times " DW_AT_entry_pc" 6 } } */
35-
/* { dg-final { scan-assembler-times " DW_AT_GNU_entry_view" 6 } } */
3633

3734
/* There are 3 DW_AT_inline attributes: one per abstract inline instance.
3835
The value of the attribute must be 0x3, meaning the function was

gcc/testsuite/gcc.dg/debug/dwarf2/inline6.c

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616

1717
/* Explicitly use dwarf-5 which uses DW_FORM_implicit_const. */
1818
/* { dg-do compile } */
19-
/* { dg-options "-O -g3 -gdwarf-5 -dA -fgnu89-inline -gno-as-loc-support" } */
19+
/* { dg-options "-O -g3 -gdwarf-5 -dA -fgnu89-inline" } */
2020

2121
/* There are 6 inlined subroutines:
2222
- One for each subroutine inlined into main, that's 3.
@@ -29,11 +29,6 @@
2929
layout. */
3030
/* { dg-final { scan-assembler-times "\\(DIE \\(\[^\n\]*\\) DW_TAG_lexical_block" 0 } } */
3131

32-
/* Each inline instance should have DW_AT_entry_pc and DW_AT_GNU_entry_view. */
33-
/* { dg-final { scan-assembler-times " DW_AT_entry_pc" 6 } } */
34-
/* { dg-final { scan-assembler-times " DW_AT_GNU_entry_view" 6 } } */
35-
/* { dg-final { scan-assembler-times "uleb128\[^\n\]*LVU\[^\n\]* (View list|Location view) (begin|end)" 0 } } */
36-
/* { dg-final { scan-assembler-times "uleb128\[^\n\]*0xffffffff\[^\n\]* (View list|Location view) (begin|end)" 0 } } */
3732

3833
/* There are 3 DW_AT_inline attributes: one per abstract inline instance.
3934
The value of the attribute must be 0x3, meaning the function was

gcc/toplev.cc

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1506,22 +1506,16 @@ process_options ()
15061506
dwarf2out_as_loc_support = dwarf2out_default_as_loc_support ();
15071507
if (!OPTION_SET_P (dwarf2out_as_locview_support))
15081508
dwarf2out_as_locview_support = dwarf2out_default_as_locview_support ();
1509-
if (dwarf2out_as_locview_support && !dwarf2out_as_loc_support)
1510-
{
1511-
if (OPTION_SET_P (dwarf2out_as_locview_support))
1512-
warning_at (UNKNOWN_LOCATION, 0,
1513-
"%<-gas-locview-support%> is forced disabled "
1514-
"without %<-gas-loc-support%>");
1515-
dwarf2out_as_locview_support = false;
1516-
}
15171509

15181510
if (!OPTION_SET_P (debug_variable_location_views))
15191511
{
15201512
debug_variable_location_views
15211513
= (flag_var_tracking
15221514
&& debug_info_level >= DINFO_LEVEL_NORMAL
15231515
&& dwarf_debuginfo_p ()
1524-
&& !dwarf_strict);
1516+
&& !dwarf_strict
1517+
&& dwarf2out_as_loc_support
1518+
&& dwarf2out_as_locview_support);
15251519
}
15261520
else if (debug_variable_location_views == -1 && dwarf_version != 5)
15271521
{

0 commit comments

Comments
 (0)