Add support for certificate revocation lists #214
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As this patch changes the API of LinkedCertificate, it also bump the version number Note: updated during cherry-picking for new Certificate interface
mbedtls/Cargo.toml
Outdated
| [package] | ||
| name = "mbedtls" | ||
| version = "0.8.2" | ||
| version = "0.8.3" |
Contributor
There was a problem hiding this comment.
You changed the interface, so these versions are not compatible with one another.
When you only update the patch version, and dependencies are defined as mbedtls = 0.8, Cargo may automatically pick up the new version. Unfortunately that will lead to compile issues.
https://doc.rust-lang.org/cargo/reference/specifying-dependencies.html
| } | ||
|
|
||
| #[test] | ||
| fn empty_crl_test() { |
Contributor
There was a problem hiding this comment.
Nitpick: Can you squash the three commits related to tests?
Fix Crl test Move Crl tests into certificate.rs
monokles
force-pushed
the
cert-revocation
branch
from
bfc5748 to
07e2cf1
Compare
Contributor
|
bors r+ |
Contributor
|
Build succeeded: |
Taowyoo
pushed a commit
that referenced
this pull request
Apr 19, 2023
214: Add support for certificate revocation lists r=raoulstrackx a=monokles Originally introduced by PR #112 but never made it into master. I cherry-picked the original commits onto a fresh branch and fixed the resulting code. Since it changes the API, the version number is bumped. Co-authored-by: Raoul Strackx <[email protected]> Co-authored-by: koentange <[email protected]>
This was referenced Apr 19, 2023
Taowyoo
pushed a commit
that referenced
this pull request
Apr 24, 2023
214: Add support for certificate revocation lists r=raoulstrackx a=monokles Originally introduced by PR #112 but never made it into master. I cherry-picked the original commits onto a fresh branch and fixed the resulting code. Since it changes the API, the version number is bumped. Co-authored-by: Raoul Strackx <[email protected]> Co-authored-by: koentange <[email protected]>
bors bot
added a commit
that referenced
this pull request
Apr 24, 2023
255: Prepare for publishing `0.8.2` r=mzohreva a=Taowyoo Back-port several PR's to fix problems that obstruct the publish - #180 - #206 - #214 only commit [441d571](441d571) - #229 Co-authored-by: bors[bot] <26634292+bors[bot]@users.noreply.github.com> Co-authored-by: Tobias Naumann <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally introduced by PR #112 but never made it into master.
I cherry-picked the original commits onto a fresh branch and fixed the resulting code.
Since it changes the API, the version number is bumped.