Skip to content

feat(snippets/php): add new flynt ACF field snippets for PHP #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 11, 2019
Merged

feat(snippets/php): add new flynt ACF field snippets for PHP #3

merged 1 commit into from
Apr 11, 2019

Conversation

@emcarru
Copy link
Contributor

@emcarru emcarru commented Apr 8, 2019

  • All fields have a trailing comma on the closing bracket: ], since it's easier when adding multiple fields.
  • Using 1/0 everywhere not true/false, because conditional logic requires 1/0 and at least this is consistent.
  • Did not yet remove or update any old snippets like flyntComponentData or flyntDynamicSubcomponent. Should this be done in a new PR or here?

@emcarru emcarru requested a review from dgrdl April 8, 2019 07:20
@dgrdl dgrdl merged commit 7cc8bd1 into master Apr 11, 2019
@dgrdl dgrdl deleted the phpFieldsUpdate branch April 11, 2019 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@dgrdl dgrdl dgrdl approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@emcarru @dgrdl