Skip to content

Conversation

@guidezpl
Copy link
Member

@guidezpl guidezpl commented Oct 2, 2025

This is what formatting all files and re-organizing imports does to all files, with the following additional changes

  • revert firebase.json
  • revert edits where imports would change docregion

Description of what this PR is changing or adding, and why:

Issues fixed by this PR (if any): #12498

PRs or commits this PR depends on (if any):

Presubmit checklist

  • If you are unwilling, or unable, to sign the CLA, even for a tiny, one-word PR, please file an issue instead of a PR.
  • If this PR is not meant to land until a future stable release, mark it as draft with an explanation.
  • This PR follows the Google Developer Documentation Style Guidelines—for example, it doesn't use i.e. or e.g., and it avoids I and we (first-person pronouns).
  • This PR uses semantic line breaks
    of 80 characters or fewer.

This is what formatting all files and re-organizing imports does to all files, with the following additional changes

- revert `firebase.json`
- revert edits where imports would change `docregion`
@guidezpl
Copy link
Member Author

guidezpl commented Oct 2, 2025

Seeking feedback from reviewers. Initial thoughts:

  • is it possible to add a test to check this for each file type?
  • which file types don't need to be formatted
    • .svg
    • ...?

@guidezpl
Copy link
Member Author

@sfshaza2 @parlough any thoughts on what should be/should not be formatted?

@parlough
Copy link
Member

parlough commented Oct 28, 2025

Sorry about the delay on this @guidezpl! We want to hold off on this until after #12548 lands.

Is it possible to add a test to check this for each file type?

It would be if we had a way to automate formatting from Dart, as we don't want to require contributors to have Node installed.

any thoughts on what should be/should not be formatted?

I think formatting SCSS, Markdown, yaml, and what remains of HTML files after the migration makes sense :)

@guidezpl
Copy link
Member Author

sure, pls land that awesome PR, and I'll circle back afterwards!

@guidezpl guidezpl closed this Oct 30, 2025
parlough pushed a commit that referenced this pull request Oct 30, 2025
Auto-format all SCSS, Markdown, yaml, HTML files, using the default VS
Code formatter and default formatting options, per
#12501 (comment).

Closes #12498
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants