Skip to content

Conversation

@moggieuk
Copy link
Contributor

@moggieuk moggieuk commented Apr 8, 2025

Description

The PR enhances the recent PR1641 in the following ways:

  1. Added config option to display spools that have filament attributes but are unavailable to MMU (user request)
  2. Adds logo for new MMX MMU (user request)
  3. Fixes small rendering error in the position of the filament in the extruder in one corner case condition
  4. Renames confusing 'unit' variable to 'unit-index' to avoid potential conflict with mmu.ts mixin
  5. Shows red "!" when the filament runs out according to spoolman but the MMU has not yet detected runout (user request)

Are there any post-deployment tasks we need to perform?

Signed-off-by

Signed-off-by: Paul Morgan [email protected]

moggieuk and others added 30 commits March 5, 2025 22:44
Signed-off-by: Pedro Lamas <[email protected]>

# Conflicts:
#	src/components/widgets/spoolman/SpoolSelectionDialog.vue
Signed-off-by: Pedro Lamas <[email protected]>

# Conflicts:
#	src/components/widgets/filesystem/FileSystem.vue
#	src/components/widgets/spoolman/SpoolSelectionDialog.vue
#	src/components/widgets/status/PrinterStatusCard.vue
Signed-off-by: Pedro Lamas <[email protected]>

# Conflicts:
#	src/components/widgets/spoolman/SpoolSelectionDialog.vue
Signed-off-by: Pedro Lamas <[email protected]>
pedrolamas and others added 21 commits March 23, 2025 19:05
Signed-off-by: Pedro Lamas <[email protected]>
Signed-off-by: Pedro Lamas <[email protected]>

# Conflicts:
#	src/store/printer/types.ts
Signed-off-by: Pedro Lamas <[email protected]>
Signed-off-by: Pedro Lamas <[email protected]>
@moggieuk
Copy link
Contributor Author

moggieuk commented Apr 8, 2025

FYI: I know you merge commit log... I had some issues syncing back with latest upstream so more commits appear that the changes warrant - not sure what happened.

@pedrolamas
Copy link
Member

FYI: I know you merge commit log... I had some issues syncing back with latest upstream so more commits appear that the changes warrant - not sure what happened

Not a problem, we squash the PRs before merging!

get gateSensorName (): string {
if (this.unitDetails(this.unit).multiGear) {
return 'Hub (Gate)'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally (and unless I am missing something here), these should be localized strings!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, possibly, but those terms are used in config and throughout doc to reference a sensor name. I think it would be confusing to have translated sensor names... The "Hub" was and add-on to help the Box Turtle and other type-B MMU's who all refer to the "gate" sensor as a "hub" sensor.

@moggieuk moggieuk marked this pull request as ready for review April 20, 2025 02:18
@pedrolamas pedrolamas added the FR - Enhancement New feature or request label Apr 20, 2025
@pedrolamas pedrolamas added this to the 1.34.2 milestone Apr 20, 2025
@pedrolamas pedrolamas merged commit 7471c36 into fluidd-core:develop Apr 21, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

FR - Enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants