-
-
Notifications
You must be signed in to change notification settings - Fork 522
feat: Enhancements to Happy Hare MMU support #1666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Paul Morgan [email protected]
Signed-off-by: Pedro Lamas <[email protected]> # Conflicts: # src/components/widgets/spoolman/SpoolSelectionDialog.vue
…s for main panel and gate editor dialog
…y mapping for a print
Signed-off-by: Pedro Lamas <[email protected]> # Conflicts: # src/components/widgets/filesystem/FileSystem.vue # src/components/widgets/spoolman/SpoolSelectionDialog.vue # src/components/widgets/status/PrinterStatusCard.vue
Signed-off-by: Pedro Lamas <[email protected]> # Conflicts: # src/components/widgets/spoolman/SpoolSelectionDialog.vue
…TG map is updated
Signed-off-by: Pedro Lamas <[email protected]>
Signed-off-by: Pedro Lamas <[email protected]>
Signed-off-by: Pedro Lamas <[email protected]>
Signed-off-by: Pedro Lamas <[email protected]>
Signed-off-by: Pedro Lamas <[email protected]> # Conflicts: # src/store/printer/types.ts
Signed-off-by: Pedro Lamas <[email protected]>
Signed-off-by: Pedro Lamas <[email protected]>
Signed-off-by: Pedro Lamas <[email protected]>
Signed-off-by: Pedro Lamas <[email protected]>
…ion of Firefox to prevent rendering problem
Signed-off-by: Pedro Lamas <[email protected]>
Signed-off-by: Pedro Lamas <[email protected]>
…rendering of filament position in extruder
|
FYI: I know you merge commit log... I had some issues syncing back with latest upstream so more commits appear that the changes warrant - not sure what happened. |
Not a problem, we squash the PRs before merging! |
| get gateSensorName (): string { | ||
| if (this.unitDetails(this.unit).multiGear) { | ||
| return 'Hub (Gate)' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally (and unless I am missing something here), these should be localized strings!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, possibly, but those terms are used in config and throughout doc to reference a sensor name. I think it would be confusing to have translated sensor names... The "Hub" was and add-on to help the Box Turtle and other type-B MMU's who all refer to the "gate" sensor as a "hub" sensor.
Description
The PR enhances the recent PR1641 in the following ways:
Are there any post-deployment tasks we need to perform?
Signed-off-by
Signed-off-by: Paul Morgan [email protected]