Skip to content

Commit 14d7072

Browse files
committed
style: removes dashboard card movement transitions
Signed-off-by: Pedro Lamas <[email protected]>
1 parent 762add9 commit 14d7072

File tree

3 files changed

+20
-58
lines changed

3 files changed

+20
-58
lines changed

src/components/common/CollapsableCard.vue

Lines changed: 2 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,6 @@
7171
id="card-content"
7272
:class="_contentClasses"
7373
:style="_contentStyles"
74-
@transitionend="transitionEvent"
7574
>
7675
<template v-if="subTitle || hasSubTitleSlot">
7776
<v-card-subtitle class="py-2">
@@ -83,7 +82,6 @@
8382
<v-divider />
8483
</template>
8584

86-
<!-- Primary Content slot -->
8785
<slot />
8886
</div>
8987
</v-expand-transition>
@@ -94,21 +92,17 @@
9492
id="card-content"
9593
:class="_contentClasses"
9694
:style="_contentStyles"
97-
@transitionend="transitionEvent"
9895
>
99-
<template
100-
v-if="subTitle || hasSubTitleSlot"
101-
>
96+
<template v-if="subTitle || hasSubTitleSlot">
10297
<v-card-subtitle class="py-2">
103-
<slot name="subTitle">
98+
<slot name="sub-title">
10499
<span v-html="subTitle" />
105100
</slot>
106101
</v-card-subtitle>
107102

108103
<v-divider />
109104
</template>
110105

111-
<!-- Primary Content slot -->
112106
<slot />
113107
</div>
114108
</v-expand-transition>
@@ -392,26 +386,6 @@ export default class CollapsableCard extends Vue {
392386
393387
mounted () {
394388
this.$emit('collapsed', this.isCollapsed)
395-
if (this.hasCollapseButtonSlot) {
396-
// this.collapsable = false
397-
}
398-
}
399-
400-
onCollapseChange (isCollapsed: boolean) {
401-
this.isCollapsed = isCollapsed
402-
}
403-
404-
onLayoutEnabled (event: Event) {
405-
this.$emit('enabled', event)
406-
}
407-
408-
transitionEvent (event: TransitionEvent) {
409-
if (
410-
event.target instanceof HTMLElement &&
411-
event.target.id === 'card-content'
412-
) {
413-
this.$emit('transition-end')
414-
}
415389
}
416390
}
417391
</script>

src/views/Dashboard.vue

Lines changed: 9 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -16,23 +16,17 @@
1616
group: 'dashboard',
1717
disabled: !inLayout,
1818
}"
19-
target=":first-child"
2019
@end="handleUpdateLayout"
2120
>
22-
<transition-group
23-
type="transition"
24-
:name="!inLayout ? 'flip-list' : undefined"
25-
>
26-
<template v-for="c in container">
27-
<component
28-
:is="c.id"
29-
v-if="inLayout || (c.enabled && !filtered(c))"
30-
:key="c.id"
31-
:menu-collapsed="menuCollapsed"
32-
class="mb-2 mb-md-4"
33-
/>
34-
</template>
35-
</transition-group>
21+
<template v-for="c in container">
22+
<component
23+
:is="c.id"
24+
v-if="inLayout || (c.enabled && !filtered(c))"
25+
:key="c.id"
26+
:menu-collapsed="menuCollapsed"
27+
class="mb-2 mb-md-4"
28+
/>
29+
</template>
3630
</app-draggable>
3731
</v-col>
3832
</template>

src/views/Diagnostics.vue

Lines changed: 9 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -43,23 +43,17 @@
4343
group: 'diagnostics',
4444
disabled: !inLayout,
4545
}"
46-
target=":first-child"
4746
@end.stop="updateLayout"
4847
>
49-
<transition-group
50-
type="transition"
51-
:name="!inLayout ? 'flip-list' : undefined"
52-
>
53-
<template v-for="c in container">
54-
<diagnostics-card
55-
v-if="c.enabled || inLayout"
56-
:key="c.id"
57-
:config="c"
58-
class="mb-2 mb-md-4"
59-
@edit="handleEditCard"
60-
/>
61-
</template>
62-
</transition-group>
48+
<template v-for="c in container">
49+
<diagnostics-card
50+
v-if="c.enabled || inLayout"
51+
:key="c.id"
52+
:config="c"
53+
class="mb-2 mb-md-4"
54+
@edit="handleEditCard"
55+
/>
56+
</template>
6357
</app-draggable>
6458
</v-col>
6559
</template>

0 commit comments

Comments
 (0)