Skip to content

fix: handle invalid http responses #508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 14, 2023
Merged

fix: handle invalid http responses #508

merged 5 commits into from
Jun 14, 2023

Conversation

bshaffer
Copy link
Collaborator

fixes #499

croensch
croensch reviewed May 12, 2023
View reviewed changes
@bshaffer bshaffer self-assigned this Jun 14, 2023
yash30201
yash30201 reviewed Jun 14, 2023
View reviewed changes
Copy link

@yash30201 yash30201 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything seemed fine, just a small comment regarding test.

@bshaffer bshaffer merged commit 91c39c7 into main Jun 14, 2023
@bshaffer bshaffer deleted the handle-bad-http-response branch June 14, 2023 19:26
@release-please release-please bot mentioned this pull request Jun 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
3 more reviewers

@croensch croensch croensch left review comments

@edudobay edudobay edudobay left review comments

@yash30201 yash30201 yash30201 left review comments

Reviewers whose approvals may not affect merge requirements
Assignees

@bshaffer bshaffer

Labels
type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CachedKeySet does not check HTTP response status code
4 participants
@bshaffer @croensch @edudobay @yash30201