Undefined: block timestamp validation logic

[whyrusleeping]

Its not clear how to validate a timestamp on a block header. The spec says it must be at least one block time past the previous block, and 'not in the future'.

I think those rules are likely incorrect, as clock skew would likely cause miners to drop a lot of blocks.

[anorth]

There's a ALLOWABLE_CLOCK_DRIFT in https://github.com/filecoin-project/specs/blob/master/mining.md#block-validation, but IMO the logic there should be expressed only once, in prose, in https://github.com/filecoin-project/specs/blob/master/validation.md (which I think is where you were looking)

[sternhenri]

Yes. Consolidation is right. Good catch (I’d never seen validation.md :b)

…

On Mon, Aug 26 2019 at 18:20, < ***@***.*** > wrote: There's a ALLOWABLE_CLOCK_DRIFT in https://github.com/filecoin-project/specs/blob/master/mining.md#block-validation , but IMO the logic there should be expressed only once, in prose, in https://github.com/filecoin-project/specs/blob/master/validation.md (which I think is where you were looking) — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub ( #458?email_source=notifications&email_token=AAZUC2ZKRTLTW7QZ662HBJLQGR6MNA5CNFSM4IPZA5D2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5GFAFA#issuecomment-525094932 ) , or mute the thread ( https://github.com/notifications/unsubscribe-auth/AAZUC277QYZPQBSSAOGHUQLQGR6MNANCNFSM4IPZA5DQ ).

[ZenGround0]

@whyrusleeping should be closing this out in #697, will post a link once merged.