feat: add env var support for warm storage and provider selection #102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvagg
force-pushed
the
rvagg/overrides
branch
from
a4dc978 to
0b91a72
Compare
Add WARM_STORAGE_ADDRESS, PROVIDER_ADDRESS, and PROVIDER_ID environment variable support to add, import, and daemon commands. Move env reading from core to commands to keep core Node.js-agnostic. Fixes: #92
rvagg
force-pushed
the
rvagg/overrides
branch
from
0b91a72 to
7ab96c1
Compare
rvagg
force-pushed
the
rvagg/overrides
branch
from
7ab96c1 to
256c8fc
Compare
|
Followed the same pattern as #104, ended up adding args for it as well, may as well given that we have a pattern to reduce code duplication. |
SgtPooki
reviewed
Oct 14, 2025
Comment on lines
187
to
+188
| rpcUrl: options.rpcUrl || RPC_URLS.calibration.websocket, | ||
| warmStorageAddress: process.env.WARM_STORAGE_ADDRESS, |
There was a problem hiding this comment.
Options should already have rpc and warmstorage set
rvagg
added a commit
that referenced
this pull request
Oct 15, 2025
rvagg
added a commit
that referenced
this pull request
Oct 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add WARM_STORAGE_ADDRESS, PROVIDER_ADDRESS, and PROVIDER_ID environment variable support to add, import, and daemon commands. Move env reading from core to commands to keep core Node.js-agnostic.
Fixes: #92
(I wanted the warmStorage override, so I did t he others while I was in there)