Fix received optional parameter issue and better debuggability #81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notanengineercom
changed the title
ffMathy
requested changes
Feb 23, 2020
Owner
ffMathy
left a comment
ffMathy
left a comment
There was a problem hiding this comment.
This is very impressive! One very minor comment needs fixing and I'll merge!
Collaborator
Author
|
Thanks, I had some time over the weekend to work on this 😄 |
Owner
|
You're quite amazing and pretty productive. You've managed to almost elliminate all open issues! It's insane. Nicely done. |
Collaborator
Author
|
Thanks man! I'm glad I've been able to do my bit. I quite like the library, it's really nice to work with. So thanks to you for creating it 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #59
The issue with the received optional parameter fixed itself with just swapping the order of the override types for TerminatingObject.
This pr replaces some of the hardcoded values around the library with typed ones. It also enhances a lot the logging output of the Substitute proxies, so hopefully no more
TypeError: Cannot convert object to primitive value.Some releases back, when doing a console.log of a non mocked property you would get the TypeError described before. Now it's something like
[Function: SubstituteJS] -> add, whereaddis the last accessed property / method of the proxy before the logging.