fix: prevent panic when *http.Response is nil (#156)

* fix: prevent panic when *http.Response is nil

Signed-off-by: Danny Kopping <[email protected]>

* fix: add error handling for sha256 download

Signed-off-by: Danny Kopping <[email protected]>

* fix: check body nilness as well

Signed-off-by: Danny Kopping <[email protected]>

---------

Signed-off-by: Danny Kopping <[email protected]>

Author: dannykopping

remote_fetch.go

@@ -50,7 +50,9 @@ func defaultRemoteFetchStrategy(remoteFetchHost string, versionStrategy VersionS
 
 		shaDownloadURL := fmt.Sprintf("%s.sha256", jarDownloadURL)
 		shaDownloadResponse, err := http.Get(shaDownloadURL)
-
+		if err != nil {
+			return fmt.Errorf("download sha256 from %s failed: %w", shaDownloadURL, err)
+		}
 		defer closeBody(shaDownloadResponse)()
 
 		if err == nil && shaDownloadResponse.StatusCode == http.StatusOK {
@@ -68,6 +70,9 @@ func defaultRemoteFetchStrategy(remoteFetchHost string, versionStrategy VersionS
 
 func closeBody(resp *http.Response) func() {
 	return func() {
+		if resp == nil || resp.Body == nil {
+			return
+		}
 		if err := resp.Body.Close(); err != nil {
 			log.Fatal(err)
 		}

remote_fetch_test.go

@@ -417,3 +417,9 @@ func Test_defaultRemoteFetchStrategy_whenContentLengthNotSet(t *testing.T) {
 	assert.NoError(t, err)
 	assert.FileExists(t, cacheLocation)
 }
+
+func Test_closeBody_NilResponse(t *testing.T) {
+	assert.NotPanics(t, func() {
+		closeBody(nil)()
+	})
+}