Commit f89a2bc
authored
Fixes apply actions method in the
# Description
in `NonHolonomicAction.apply_actions()` the velocity command was
incorrectly named `self.joint_vel` instead of `self._joint_vel_command`
as initialized in `NonHolonomicAction.__init__()`. This causes an error
when trying to instantiate the action config. I have corrected
and tested that it works.
## Type of change
- Bug fix (non-breaking change which fixes an issue)
## Checklist
- [X] I have run the [`pre-commit` checks](https://pre-commit.com/) with
`./orbit.sh --format`
- [X] I have made corresponding changes to the documentation
- [X] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [X] I have run all the tests with `./orbit.sh --test` and they pass
- [X] I have updated the changelog and the corresponding version in the
extension's `config/extension.toml` file
- [ ] I have added my name to the `CONTRIBUTORS.md` or my name already
exists thereNonHolonomicAction action term class (isaac-sim#317)1 parent bf42e01 commit f89a2bc
File tree
3 files changed
+15
-5
lines changed- source/extensions/omni.isaac.orbit
- config
- docs
- omni/isaac/orbit/envs/mdp/actions
3 files changed
+15
-5
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | 3 | | |
4 | | - | |
| 4 | + | |
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | 3 | | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
4 | 13 | | |
5 | 14 | | |
6 | 15 | | |
| |||
11 | 20 | | |
12 | 21 | | |
13 | 22 | | |
| 23 | + | |
14 | 24 | | |
15 | 25 | | |
16 | 26 | | |
| |||
Lines changed: 4 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
134 | 134 | | |
135 | 135 | | |
136 | 136 | | |
137 | | - | |
138 | | - | |
139 | | - | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
140 | 140 | | |
141 | | - | |
| 141 | + | |
0 commit comments