Skip to content

Commit f89a2bc

Browse files
authored
Fixes apply actions method in the NonHolonomicAction action term class (isaac-sim#317)
# Description in `NonHolonomicAction.apply_actions()` the velocity command was incorrectly named `self.joint_vel` instead of `self._joint_vel_command` as initialized in `NonHolonomicAction.__init__()`. This causes an error when trying to instantiate the action config. I have corrected and tested that it works. ## Type of change - Bug fix (non-breaking change which fixes an issue) ## Checklist - [X] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./orbit.sh --format` - [X] I have made corresponding changes to the documentation - [X] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [X] I have run all the tests with `./orbit.sh --test` and they pass - [X] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [ ] I have added my name to the `CONTRIBUTORS.md` or my name already exists there
1 parent bf42e01 commit f89a2bc

File tree

3 files changed

+15
-5
lines changed

3 files changed

+15
-5
lines changed

source/extensions/omni.isaac.orbit/config/extension.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
[package]
22

33
# Note: Semantic Versioning is used: https://semver.org/
4-
version = "0.15.3"
4+
version = "0.15.4"
55

66
# Description
77
title = "ORBIT framework for Robot Learning"

source/extensions/omni.isaac.orbit/docs/CHANGELOG.rst

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,15 @@
11
Changelog
22
---------
33

4+
0.15.4 (2024-03-22)
5+
~~~~~~~~~~~~~~~~~~~
6+
7+
Fixed
8+
^^^^^
9+
10+
* Fixed the NonHolonomicActionCfg variable naming from joint_vel to _joint_vel_command to match the initialized variable in the init() function.
11+
12+
413
0.15.3 (2024-03-21)
514
~~~~~~~~~~~~~~~~~~~
615

@@ -11,6 +20,7 @@ Added
1120

1221
Fixed
1322
^^^^^
23+
1424
* Moved class variables in :class:`omni.isaac.orbit.scene.InteractiveScene` to correctly be assigned as
1525
instance variables.
1626
* Removed custom ``__del__`` magic method from :class:`omni.isaac.orbit.scene.InteractiveScene`.

source/extensions/omni.isaac.orbit/omni/isaac/orbit/envs/mdp/actions/non_holonomic_actions.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -134,8 +134,8 @@ def apply_actions(self):
134134
quat_w = self._asset.data.body_quat_w[:, self._body_idx]
135135
yaw_w = euler_xyz_from_quat(quat_w)[2]
136136
# compute joint velocities targets
137-
self.joint_vel[:, 0] = torch.cos(yaw_w) * self.processed_actions[:, 0] # x
138-
self.joint_vel[:, 1] = torch.sin(yaw_w) * self.processed_actions[:, 0] # y
139-
self.joint_vel[:, 2] = self.processed_actions[:, 1] # yaw
137+
self._joint_vel_command[:, 0] = torch.cos(yaw_w) * self.processed_actions[:, 0] # x
138+
self._joint_vel_command[:, 1] = torch.sin(yaw_w) * self.processed_actions[:, 0] # y
139+
self._joint_vel_command[:, 2] = self.processed_actions[:, 1] # yaw
140140
# set the joint velocity targets
141-
self._asset.set_joint_velocity_target(self.joint_vel, joint_ids=self._joint_ids)
141+
self._asset.set_joint_velocity_target(self._joint_vel_command, joint_ids=self._joint_ids)

0 commit comments

Comments
 (0)