Skip to content

Conversation

@hwine
Copy link

@hwine hwine commented May 19, 2022

Apparently, GitHub docs were changed to assume a default doc version
of 'free-pro-team@latest', and droped support for specifying that
explicitly.

Additionally, remove the '/en' locale specifier, so the browser can
negotiate the appropriate one for every user.

Changes were done mechanically using

for f in $(rg '@latest' -l) ; do
    sed --in-place=.doc \
        -e 's:docs.github.com/en/free-pro-team@latest/:docs.github.com/:g' \
        $f
done

N.B. the CONTRIBUTING.md section on documentation changes appears to reference an older procedure. Please let me know if a different procedure should be used now.

Fixes #135

Apparently, GitHub docs were changes to _assume_ a default doc version
of 'free-pro-team@latest', and drop support for specifying that
explicitly.

Additionally, remove the '/en' locale specifier, so the browser can
negotiate the appropriate one for every user.

Changes were done mechanically using
```bash
for f in $(rg '@latest' -l) ; do
    sed --in-place=.doc \
        -e 's:docs.github.com/en/free-pro-team@latest/:docs.github.com/:g' \
        $f
done
```
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@jph00 jph00 merged commit aa834d0 into AnswerDotAI:master Jul 23, 2022
@jph00
Copy link
Contributor

jph00 commented Jul 23, 2022

Many thanks!

@jph00 jph00 added the bug Something isn't working label Jul 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

README has many broken URLs

2 participants