Skip to content

Apply build script changes for RN to main #34640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 30, 2025
Merged

Apply build script changes for RN to main #34640

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ff5e07f
[Release] Update build script to properly set React Native's renderer…
cipolleschi Jul 23, 2025
26a3e23
Run prettier
jackpope Sep 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
59 changes: 25 additions & 34 deletions scripts/rollup/build-all-release-channels.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,8 +221,7 @@ function processStable(buildDir) {
);
}

const rnVersionString =
ReactVersion + '-native-fb-' + sha + '-' + dateString;
const rnVersionString = ReactVersion + '-native-fb-' + sha + '-' + dateString;
if (fs.existsSync(buildDir + '/facebook-react-native')) {
updatePlaceholderReactVersionInCompiledArtifacts(
buildDir + '/facebook-react-native',
Expand All @@ -231,9 +230,16 @@ function processStable(buildDir) {
}

if (fs.existsSync(buildDir + '/react-native')) {
updatePlaceholderReactVersionInCompiledArtifactsFb(
updatePlaceholderReactVersionInCompiledArtifacts(
buildDir + '/react-native',
rnVersionString
rnVersionString,
(filename) => filename.endsWith('.fb.js')
);

updatePlaceholderReactVersionInCompiledArtifacts(
buildDir + '/react-native',
ReactVersion,
(filename) => !filename.endsWith('.fb.js') && filename.endsWith('.js')
);
}

Expand Down Expand Up @@ -340,9 +346,16 @@ function processExperimental(buildDir, version) {
}

if (fs.existsSync(buildDir + '/react-native')) {
updatePlaceholderReactVersionInCompiledArtifactsFb(
updatePlaceholderReactVersionInCompiledArtifacts(
buildDir + '/react-native',
rnVersionString
rnVersionString,
(filename) => filename.endsWith('.fb.js')
);

updatePlaceholderReactVersionInCompiledArtifacts(
buildDir + '/react-native',
ReactVersion,
(filename) => !filename.endsWith('.fb.js') && filename.endsWith('.js')
);
}

Expand Down Expand Up @@ -437,38 +450,15 @@ function updatePackageVersions(

function updatePlaceholderReactVersionInCompiledArtifacts(
artifactsDirectory,
newVersion
newVersion,
filteringClosure
) {
// Update the version of React in the compiled artifacts by searching for
// the placeholder string and replacing it with a new one.
const artifactFilenames = String(
spawnSync('grep', [
'-lr',
PLACEHOLDER_REACT_VERSION,
'--',
artifactsDirectory,
]).stdout
)
.trim()
.split('\n')
.filter(filename => filename.endsWith('.js'));

for (const artifactFilename of artifactFilenames) {
const originalText = fs.readFileSync(artifactFilename, 'utf8');
const replacedText = originalText.replaceAll(
PLACEHOLDER_REACT_VERSION,
newVersion
);
fs.writeFileSync(artifactFilename, replacedText);
if (filteringClosure == null) {
filteringClosure = filename => filename.endsWith('.js')
}
}

function updatePlaceholderReactVersionInCompiledArtifactsFb(
artifactsDirectory,
newVersion
) {
// Update the version of React in the compiled artifacts by searching for
// the placeholder string and replacing it with a new one.
const artifactFilenames = String(
spawnSync('grep', [
'-lr',
Expand All @@ -479,7 +469,7 @@ function updatePlaceholderReactVersionInCompiledArtifactsFb(
)
.trim()
.split('\n')
.filter(filename => filename.endsWith('.fb.js'));
.filter(filteringClosure);

for (const artifactFilename of artifactFilenames) {
const originalText = fs.readFileSync(artifactFilename, 'utf8');
Expand All @@ -491,6 +481,7 @@ function updatePlaceholderReactVersionInCompiledArtifactsFb(
}
}


/**
* cross-platform alternative to `rsync -ar`
* @param {string} source
Expand Down
Loading