[Fizz] Update postpone abort semantics when prerendering #30541
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
CLA Signed
React Core Team
gnoff
commented
Jul 31, 2024
Comment on lines
+3799
to
+3805
| if (trackedPostpones !== null && segment !== null) { | ||
| // We are prerendering. We don't want to fatal when the shell postpones | ||
| // we just need to mark it as postponed. | ||
| logPostpone(request, postponeInstance.message, errorInfo, null); | ||
| trackPostpone(request, trackedPostpones, task, segment); | ||
| finishedTask(request, null, segment); | ||
| } else { |
Collaborator
Author
There was a problem hiding this comment.
The factoring here isn't great but I don't want to completely refactor this code. I have to recheck wether the segment actually exists to mark it as postponable but if we're tracking postpones it would definitely exist. But mabye I should
|
Comparing: 2b00018...2afe9c6 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show |
sebmarkbage
reviewed
Jul 31, 2024
| ); | ||
| }); | ||
|
|
||
| // @gate experimental |
Collaborator
There was a problem hiding this comment.
Should be gated on enablePostpone I guess.
sebmarkbage
approved these changes
Jul 31, 2024
When aborting with a postpone value in Fizz if any tasks are still pending in the root while prerendering the prerender will fatally error. This is different from postponing imperatively in a root task and really the semantics should be the same. This change updatse React to treat an abort with a postpone value as a postponed root rather than a fatal error.
github-actions bot
pushed a commit
that referenced
this pull request
Jul 31, 2024
When aborting with a postpone value in Fizz if any tasks are still pending in the root while prerendering the prerender will fatally error. This is different from postponing imperatively in a root task and really the semantics should be the same. This change updates React to treat an abort with a postpone value as a postponed root rather than a fatal error. DiffTrain build for [a7d1240](a7d1240)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When aborting with a postpone value in Fizz if any tasks are still pending in the root while prerendering the prerender will fatally error. This is different from postponing imperatively in a root task and really the semantics should be the same. This change updates React to treat an abort with a postpone value as a postponed root rather than a fatal error.