Skip to content

Convert ReactFreshMultipleRenderer to createRoot #28000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 19, 2024
+7 −3
Merged

Convert ReactFreshMultipleRenderer to createRoot #28000

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions packages/react-refresh/src/__tests__/ReactFreshMultipleRenderer-test.internal.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,8 @@ if (__DEV__) {
ReactFreshRuntime = require('react-refresh/runtime');
ReactFreshRuntime.injectIntoGlobalHook(global);
}
const ReactDOM = require('react-dom');
const ReactDOMClient = require('react-dom/client');
const act = require('internal-test-utils').act;

jest.resetModules();
const ReactART = require('react-art');
Expand All @@ -41,7 +42,7 @@ describe('ReactFresh', () => {
}
});

it('can update components managed by different renderers independently', () => {
it('can update components managed by different renderers independently', async () => {
if (__DEV__) {
const InnerV1 = function () {
return <ReactART.Shape fill="blue" />;
Expand All @@ -59,7 +60,10 @@ describe('ReactFresh', () => {
};
ReactFreshRuntime.register(OuterV1, 'Outer');

ReactDOM.render(<OuterV1 />, container);
const root = ReactDOMClient.createRoot(container);
await act(() => {
root.render(<OuterV1 />);
});
const el = container.firstChild;
const pathEl = el.querySelector('path');
expect(el.style.color).toBe('blue');
Expand Down