Skip to content

Move the Error creation to be lazy #24728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 15, 2022
Merged

Move the Error creation to be lazy #24728

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 6 additions & 10 deletions packages/react-dom/src/server/ReactDOMFizzServerNode.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,8 @@ function createDrainHandler(destination, request) {
}

function createAbortHandler(request, reason) {
return () => abort(request, reason);
// eslint-disable-next-line react-internal/prod-error-codes
return () => abort(request, new Error(reason));
}

type Options = {|
Expand All @@ -49,7 +50,7 @@ type Options = {|
type PipeableStream = {|
// Cancel any pending I/O and put anything remaining into
// client rendered mode.
abort(): void,
abort(reason: mixed): void,
pipe<T: Writable>(destination: T): T,
|};

Expand Down Expand Up @@ -94,21 +95,16 @@ function renderToPipeableStream(
'error',
createAbortHandler(
request,
// eslint-disable-next-line react-internal/prod-error-codes
new Error('The destination stream errored while writing data.'),
'The destination stream errored while writing data.',
),
);
destination.on(
'close',
createAbortHandler(
request,
// eslint-disable-next-line react-internal/prod-error-codes
new Error('The destination stream closed early.'),
),
createAbortHandler(request, 'The destination stream closed early.'),
);
return destination;
},
abort(reason) {
abort(reason: mixed) {
abort(request, reason);
},
};
Expand Down