Add more tests for suppressHydrationWarning #24275
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
React Core Team
gaearon
commented
Apr 4, 2022
| return ( | ||
| <div> | ||
| <span suppressHydrationWarning={true}> | ||
| {isClient ? null : 'Server'} |
Collaborator
Author
There was a problem hiding this comment.
So, {isClient ? null : 'Server'} throws. But {isClient ? 'Client' : null} works fine. {isClient ? 'Client' : 'Server'} also works fine. Should we make it consistent?
|
Comparing: fc47cb1...ac628a3 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
Collaborator
Author
|
it's just a test |
rickhanlonii
pushed a commit
that referenced
this pull request
Apr 13, 2022
* More tests for suppressHydrationWarning * Move suppressHydration tests to new file * Extract more tests * Test name * Test legacy behavior too
rickhanlonii
pushed a commit
that referenced
this pull request
Apr 14, 2022
* More tests for suppressHydrationWarning * Move suppressHydration tests to new file * Extract more tests * Test name * Test legacy behavior too
zhengjitf
pushed a commit
to zhengjitf/react
that referenced
this pull request
Apr 15, 2022
* More tests for suppressHydrationWarning * Move suppressHydration tests to new file * Extract more tests * Test name * Test legacy behavior too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copy paste into another file and add a few more cases to document the current behavior.