Add flag concurrent root to Fabric render function #21552
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Comparing: a731a51...46c279c Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
sammy-SC
force-pushed
the
rn-concurrent-root
branch
from
83e6cd3 to
a345266
Compare
sammy-SC
force-pushed
the
rn-concurrent-root
branch
from
a345266 to
aa337a9
Compare
gaearon
reviewed
May 24, 2021
Collaborator
gaearon
left a comment
gaearon
left a comment
There was a problem hiding this comment.
Have you considered mirroring the new createRoot API instead, like we do in DOM? It would make sense to me if those were aligned, unless there was some specific conversation about not doing that.
rickhanlonii
approved these changes
May 24, 2021
Member
|
Nice! |
facebook-github-bot
pushed a commit
to facebook/react-native
that referenced
this pull request
May 25, 2021
Summary: This sync includes the following changes: - **[459c34fde](facebook/react@459c34fde )**: Add flag concurrent root ([#21552](facebook/react#21552)) //<Samuel Susla>// Changelog: [General][Changed] - React Native sync for revisions 3169430...459c34f jest_e2e[run_all_tests] Reviewed By: mdvacca Differential Revision: D28641463 fbshipit-source-id: 0930a8f82e49b222582995e4c8b2c8a41564bf53
koto
pushed a commit
to koto/react
that referenced
this pull request
Jun 15, 2021
* Add flag concurrent root to Fabric render function * Lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
To enable Concurrent Features in React Native, we need to pass flag to render surface with concurrent root.
Test Plan
Tested separately with React Native.