Skip to content

Commit ff3f1fa

Browse files
committed
[RN] Set enableOwnerStacks and enableUseDeferredValueInitialArg to false
In www, the experimental versions get a .modern.js or .classic.js prefix and get copied into the same folder. In RN, they don't seem to have .modern.js and .classic.js versions so they end up getting the same name. sebmarkbage's theory is that what happens is that they then override the file that was already there. So depending on if experimental or stable build finishes first you get a different version at the end. It doesn't make sense to use `__EXPERIMENTAL__` for flags in native-fb since there's no modern/classic split there. So that flag should just be hardcoded to true or false and then it doesn't matter which one finishes first. We don't support experimental builds in OSS RN neither so the same thing could happen with [`enableOwnerStacks`](https://github.com/facebook/react/blob/5dcf3ca8d45a276a8b4cee0cedd234967661ca35/packages/shared/forks/ReactFeatureFlags.native-oss.js#L60). You can see that the build errors in the previous PR but passes after these flag changes. ghstack-source-id: d10f37b Pull Request resolved: #30322
1 parent df5f273 commit ff3f1fa

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

packages/shared/forks/ReactFeatureFlags.native-oss.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ export const enableLegacyFBSupport = false;
5757
export const enableLegacyHidden = false;
5858
export const enableNoCloningMemoCache = false;
5959
export const enableObjectFiber = false;
60-
export const enableOwnerStacks = __EXPERIMENTAL__;
60+
export const enableOwnerStacks = false;
6161
export const enablePostpone = false;
6262
export const enableReactTestRendererWarning = false;
6363
export const enableRefAsProp = true;

packages/shared/forks/ReactFeatureFlags.test-renderer.native-fb.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ export const enableTaint = true;
6969
export const enableTransitionTracing = false;
7070
export const enableTrustedTypesIntegration = false;
7171
export const enableUpdaterTracking = false;
72-
export const enableUseDeferredValueInitialArg = __EXPERIMENTAL__;
72+
export const enableUseDeferredValueInitialArg = true;
7373
export const enableUseEffectEventHook = false;
7474
export const enableUseMemoCacheHook = true;
7575
export const favorSafetyOverHydrationPerf = true;

0 commit comments

Comments
 (0)