Skip to content

Commit eb16b74

Browse files
committed
Update tests
1 parent c61110e commit eb16b74

File tree

2 files changed

+32
-35
lines changed

2 files changed

+32
-35
lines changed

packages/react-dom/src/__tests__/ReactDOMComponent-test.js

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -2618,27 +2618,27 @@ describe('ReactDOMComponent', () => {
26182618
it('warns on the ambiguous string value "false"', function() {
26192619
let el;
26202620
expect(() => {
2621-
el = ReactTestUtils.renderIntoDocument(<div hidden="false" />);
2621+
el = ReactTestUtils.renderIntoDocument(<div disabled="false" />);
26222622
}).toErrorDev(
2623-
'Received the string `false` for the boolean attribute `hidden`. ' +
2623+
'Received the string `false` for the boolean attribute `disabled`. ' +
26242624
'The browser will interpret it as a truthy value. ' +
2625-
'Did you mean hidden={false}?',
2625+
'Did you mean disabled={false}?',
26262626
);
26272627

2628-
expect(el.getAttribute('hidden')).toBe('');
2628+
expect(el.getAttribute('disabled')).toBe('');
26292629
});
26302630

26312631
it('warns on the potentially-ambiguous string value "true"', function() {
26322632
let el;
26332633
expect(() => {
2634-
el = ReactTestUtils.renderIntoDocument(<div hidden="true" />);
2634+
el = ReactTestUtils.renderIntoDocument(<div disabled="true" />);
26352635
}).toErrorDev(
2636-
'Received the string `true` for the boolean attribute `hidden`. ' +
2636+
'Received the string `true` for the boolean attribute `disabled`. ' +
26372637
'Although this works, it will not work as expected if you pass the string "false". ' +
2638-
'Did you mean hidden={true}?',
2638+
'Did you mean disabled={true}?',
26392639
);
26402640

2641-
expect(el.getAttribute('hidden')).toBe('');
2641+
expect(el.getAttribute('disabled')).toBe('');
26422642
});
26432643
});
26442644

packages/react-dom/src/__tests__/ReactDOMServerIntegrationAttributes-test.js

Lines changed: 24 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -85,71 +85,68 @@ describe('ReactDOMServerIntegration', () => {
8585

8686
describe('boolean properties', function() {
8787
itRenders('boolean prop with true value', async render => {
88-
const e = await render(<div hidden={true} />);
89-
expect(e.getAttribute('hidden')).toBe('');
88+
const e = await render(<div disabled={true} />);
89+
expect(e.getAttribute('disabled')).toBe('');
9090
});
9191

9292
itRenders('boolean prop with false value', async render => {
93-
const e = await render(<div hidden={false} />);
94-
expect(e.getAttribute('hidden')).toBe(null);
93+
const e = await render(<div disabled={false} />);
94+
expect(e.getAttribute('disabled')).toBe(null);
9595
});
9696

9797
itRenders('boolean prop with self value', async render => {
98-
const e = await render(<div hidden="hidden" />);
99-
expect(e.getAttribute('hidden')).toBe('');
98+
const e = await render(<div disabled="disabled" />);
99+
expect(e.getAttribute('disabled')).toBe('');
100100
});
101101

102-
// this does not seem like correct behavior, since hidden="" in HTML indicates
103-
// that the boolean property is present. however, it is how the current code
104-
// behaves, so the test is included here.
105102
itRenders('boolean prop with "" value', async render => {
106-
const e = await render(<div hidden="" />);
107-
expect(e.getAttribute('hidden')).toBe(null);
103+
const e = await render(<div disabled="" />);
104+
expect(e.getAttribute('disabled')).toBe(null);
108105
});
109106

110107
// this seems like it might mask programmer error, but it's existing behavior.
111108
itRenders('boolean prop with string value', async render => {
112-
const e = await render(<div hidden="foo" />);
113-
expect(e.getAttribute('hidden')).toBe('');
109+
const e = await render(<div disabled="foo" />);
110+
expect(e.getAttribute('disabled')).toBe('');
114111
});
115112

116113
// this seems like it might mask programmer error, but it's existing behavior.
117114
itRenders('boolean prop with array value', async render => {
118-
const e = await render(<div hidden={['foo', 'bar']} />);
119-
expect(e.getAttribute('hidden')).toBe('');
115+
const e = await render(<div disabled={['foo', 'bar']} />);
116+
expect(e.getAttribute('disabled')).toBe('');
120117
});
121118

122119
// this seems like it might mask programmer error, but it's existing behavior.
123120
itRenders('boolean prop with object value', async render => {
124-
const e = await render(<div hidden={{foo: 'bar'}} />);
125-
expect(e.getAttribute('hidden')).toBe('');
121+
const e = await render(<div disabled={{foo: 'bar'}} />);
122+
expect(e.getAttribute('disabled')).toBe('');
126123
});
127124

128125
// this seems like it might mask programmer error, but it's existing behavior.
129126
itRenders('boolean prop with non-zero number value', async render => {
130-
const e = await render(<div hidden={10} />);
131-
expect(e.getAttribute('hidden')).toBe('');
127+
const e = await render(<div disabled={10} />);
128+
expect(e.getAttribute('disabled')).toBe('');
132129
});
133130

134131
// this seems like it might mask programmer error, but it's existing behavior.
135132
itRenders('boolean prop with zero value', async render => {
136-
const e = await render(<div hidden={0} />);
137-
expect(e.getAttribute('hidden')).toBe(null);
133+
const e = await render(<div disabled={0} />);
134+
expect(e.getAttribute('disabled')).toBe(null);
138135
});
139136

140137
itRenders('no boolean prop with null value', async render => {
141-
const e = await render(<div hidden={null} />);
142-
expect(e.hasAttribute('hidden')).toBe(false);
138+
const e = await render(<div disabled={null} />);
139+
expect(e.hasAttribute('disabled')).toBe(false);
143140
});
144141

145142
itRenders('no boolean prop with function value', async render => {
146-
const e = await render(<div hidden={function() {}} />, 1);
147-
expect(e.hasAttribute('hidden')).toBe(false);
143+
const e = await render(<div disabled={function() {}} />, 1);
144+
expect(e.hasAttribute('disabled')).toBe(false);
148145
});
149146

150147
itRenders('no boolean prop with symbol value', async render => {
151-
const e = await render(<div hidden={Symbol('foo')} />, 1);
152-
expect(e.hasAttribute('hidden')).toBe(false);
148+
const e = await render(<div disabled={Symbol('foo')} />, 1);
149+
expect(e.hasAttribute('disabled')).toBe(false);
153150
});
154151
});
155152

0 commit comments

Comments
 (0)