Protect against generating stacks failing

Errors while generating stacks will bubble to the root. Since this technique
is a bit sketchy, we should probably protect against it.

Author: sebmarkbage

packages/react-dom/src/__tests__/ReactErrorBoundaries-test.internal.js

@@ -2440,13 +2440,11 @@ describe('ReactErrorBoundaries', () => {
     );
   });
 
-  it('should catch errors from errors in the throw phase from errors', () => {
+  it('should protect errors from errors in the stack generation', () => {
     const container = document.createElement('div');
 
     const evilError = {
-      get message() {
-        throw new Error('gotta catch em all');
-      },
+      message: 'Should catch this',
       get stack() {
         throw new Error('gotta catch em all');
       },
@@ -2472,7 +2470,7 @@ describe('ReactErrorBoundaries', () => {
     );
 
     expect(container.textContent).toContain(
-      'Caught an error: gotta catch em all.',
+      'Caught an error: Should catch this.',
     );
   });
 });

packages/react-reconciler/src/ReactFiberComponentStack.js

@@ -59,11 +59,15 @@ function describeFiber(fiber: Fiber): string {
 }
 
 export function getStackByFiberInDevAndProd(workInProgress: Fiber): string {
-  let info = '';
-  let node = workInProgress;
-  do {
-    info += describeFiber(node);
-    node = node.return;
-  } while (node);
-  return info;
+  try {
+    let info = '';
+    let node = workInProgress;
+    do {
+      info += describeFiber(node);
+      node = node.return;
+    } while (node);
+    return info;
+  } catch (x) {
+    return '\nError generating stack: ' + x.message + '\n' + x.stack;
+  }
 }