Skip to content

Commit ae90e9f

Browse files
jackpopejackpope
committed
Clean up enableUnifiedSyncLane flag (#30062)
`enableUnifiedSyncLane` now passes everywhere. Let's clean it up Implemented with #27646 Flag enabled with #27646, #28269, #29052 DiffTrain build for [c21bcd6](c21bcd6)
1 parent 174a36c commit ae90e9f

34 files changed

+158
-260
lines changed

‎compiled/facebook-www/REVISION‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
0b724e9e9c6469983f73631edb2e6abcc9c1193b
1+
c21bcd627b6a8f31548edfc149dd3b879fea6558

‎compiled/facebook-www/REVISION_TRANSFORMS‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
0b724e9e9c6469983f73631edb2e6abcc9c1193b
1+
c21bcd627b6a8f31548edfc149dd3b879fea6558

‎compiled/facebook-www/React-dev.classic.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1987,7 +1987,7 @@ __DEV__ &&
19871987
exports.useTransition = function () {
19881988
return resolveDispatcher().useTransition();
19891989
};
1990-
exports.version = "19.0.0-www-classic-0b724e9e9c-20240621";
1990+
exports.version = "19.0.0-www-classic-c21bcd627b-20240624";
19911991
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
19921992
"function" ===
19931993
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

‎compiled/facebook-www/React-dev.modern.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1967,7 +1967,7 @@ __DEV__ &&
19671967
exports.useTransition = function () {
19681968
return resolveDispatcher().useTransition();
19691969
};
1970-
exports.version = "19.0.0-www-modern-0b724e9e9c-20240621";
1970+
exports.version = "19.0.0-www-modern-c21bcd627b-20240624";
19711971
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
19721972
"function" ===
19731973
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

‎compiled/facebook-www/React-prod.classic.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -665,4 +665,4 @@ exports.useSyncExternalStore = function (
665665
exports.useTransition = function () {
666666
return ReactSharedInternals.H.useTransition();
667667
};
668-
exports.version = "19.0.0-www-classic-0b724e9e9c-20240621";
668+
exports.version = "19.0.0-www-classic-c21bcd627b-20240624";

‎compiled/facebook-www/React-prod.modern.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -665,4 +665,4 @@ exports.useSyncExternalStore = function (
665665
exports.useTransition = function () {
666666
return ReactSharedInternals.H.useTransition();
667667
};
668-
exports.version = "19.0.0-www-modern-0b724e9e9c-20240621";
668+
exports.version = "19.0.0-www-modern-c21bcd627b-20240624";

‎compiled/facebook-www/React-profiling.classic.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -669,7 +669,7 @@ exports.useSyncExternalStore = function (
669669
exports.useTransition = function () {
670670
return ReactSharedInternals.H.useTransition();
671671
};
672-
exports.version = "19.0.0-www-classic-0b724e9e9c-20240621";
672+
exports.version = "19.0.0-www-classic-c21bcd627b-20240624";
673673
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
674674
"function" ===
675675
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

‎compiled/facebook-www/React-profiling.modern.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -669,7 +669,7 @@ exports.useSyncExternalStore = function (
669669
exports.useTransition = function () {
670670
return ReactSharedInternals.H.useTransition();
671671
};
672-
exports.version = "19.0.0-www-modern-0b724e9e9c-20240621";
672+
exports.version = "19.0.0-www-modern-c21bcd627b-20240624";
673673
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
674674
"function" ===
675675
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

‎compiled/facebook-www/ReactART-dev.classic.js‎

Lines changed: 6 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -940,10 +940,8 @@ __DEV__ &&
940940
}
941941
}
942942
function getHighestPriorityLanes(lanes) {
943-
if (enableUnifiedSyncLane) {
944-
var pendingSyncLanes = lanes & SyncUpdateLanes;
945-
if (0 !== pendingSyncLanes) return pendingSyncLanes;
946-
}
943+
var pendingSyncLanes = lanes & SyncUpdateLanes;
944+
if (0 !== pendingSyncLanes) return pendingSyncLanes;
947945
switch (lanes & -lanes) {
948946
case SyncHydrationLane:
949947
return SyncHydrationLane;
@@ -7323,7 +7321,7 @@ __DEV__ &&
73237321
JSCompiler_temp = workInProgressRoot;
73247322
if (null !== JSCompiler_temp) {
73257323
nextProps = renderLanes & -renderLanes;
7326-
if (enableUnifiedSyncLane && 0 !== (nextProps & SyncUpdateLanes))
7324+
if (0 !== (nextProps & SyncUpdateLanes))
73277325
nextProps = SyncHydrationLane;
73287326
else
73297327
switch (nextProps) {
@@ -14857,7 +14855,6 @@ __DEV__ &&
1485714855
enableDebugTracing = dynamicFeatureFlags.enableDebugTracing,
1485814856
enableLazyContextPropagation =
1485914857
dynamicFeatureFlags.enableLazyContextPropagation,
14860-
enableUnifiedSyncLane = dynamicFeatureFlags.enableUnifiedSyncLane,
1486114858
enableRetryLaneExpiration = dynamicFeatureFlags.enableRetryLaneExpiration,
1486214859
enableTransitionTracing = dynamicFeatureFlags.enableTransitionTracing,
1486314860
enableDeferRootSchedulingToMicrotask =
@@ -14962,9 +14959,7 @@ __DEV__ &&
1496214959
InputContinuousLane = 8,
1496314960
DefaultHydrationLane = 16,
1496414961
DefaultLane = 32,
14965-
SyncUpdateLanes = enableUnifiedSyncLane
14966-
? SyncLane | InputContinuousLane | DefaultLane
14967-
: SyncLane,
14962+
SyncUpdateLanes = SyncLane | InputContinuousLane | DefaultLane,
1496814963
TransitionHydrationLane = 64,
1496914964
TransitionLanes = 4194176,
1497014965
RetryLanes = 62914560,
@@ -16934,14 +16929,14 @@ __DEV__ &&
1693416929
scheduleRoot: scheduleRoot,
1693516930
setRefreshHandler: setRefreshHandler,
1693616931
getCurrentFiber: getCurrentFiberForDevTools,
16937-
reconcilerVersion: "19.0.0-www-classic-0b724e9e9c-20240621"
16932+
reconcilerVersion: "19.0.0-www-classic-c21bcd627b-20240624"
1693816933
});
1693916934
})({
1694016935
findFiberByHostInstance: function () {
1694116936
return null;
1694216937
},
1694316938
bundleType: 1,
16944-
version: "19.0.0-www-classic-0b724e9e9c-20240621",
16939+
version: "19.0.0-www-classic-c21bcd627b-20240624",
1694516940
rendererPackageName: "react-art"
1694616941
});
1694716942
var ClippingRectangle = TYPES.CLIPPING_RECTANGLE,

‎compiled/facebook-www/ReactART-dev.modern.js‎

Lines changed: 6 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -937,10 +937,8 @@ __DEV__ &&
937937
}
938938
}
939939
function getHighestPriorityLanes(lanes) {
940-
if (enableUnifiedSyncLane) {
941-
var pendingSyncLanes = lanes & SyncUpdateLanes;
942-
if (0 !== pendingSyncLanes) return pendingSyncLanes;
943-
}
940+
var pendingSyncLanes = lanes & SyncUpdateLanes;
941+
if (0 !== pendingSyncLanes) return pendingSyncLanes;
944942
switch (lanes & -lanes) {
945943
case SyncHydrationLane:
946944
return SyncHydrationLane;
@@ -7088,7 +7086,7 @@ __DEV__ &&
70887086
JSCompiler_temp = workInProgressRoot;
70897087
if (null !== JSCompiler_temp) {
70907088
nextProps = renderLanes & -renderLanes;
7091-
if (enableUnifiedSyncLane && 0 !== (nextProps & SyncUpdateLanes))
7089+
if (0 !== (nextProps & SyncUpdateLanes))
70927090
nextProps = SyncHydrationLane;
70937091
else
70947092
switch (nextProps) {
@@ -14294,7 +14292,6 @@ __DEV__ &&
1429414292
enableDebugTracing = dynamicFeatureFlags.enableDebugTracing,
1429514293
enableLazyContextPropagation =
1429614294
dynamicFeatureFlags.enableLazyContextPropagation,
14297-
enableUnifiedSyncLane = dynamicFeatureFlags.enableUnifiedSyncLane,
1429814295
enableRetryLaneExpiration = dynamicFeatureFlags.enableRetryLaneExpiration,
1429914296
enableTransitionTracing = dynamicFeatureFlags.enableTransitionTracing,
1430014297
enableDeferRootSchedulingToMicrotask =
@@ -14398,9 +14395,7 @@ __DEV__ &&
1439814395
InputContinuousLane = 8,
1439914396
DefaultHydrationLane = 16,
1440014397
DefaultLane = 32,
14401-
SyncUpdateLanes = enableUnifiedSyncLane
14402-
? SyncLane | InputContinuousLane | DefaultLane
14403-
: SyncLane,
14398+
SyncUpdateLanes = SyncLane | InputContinuousLane | DefaultLane,
1440414399
TransitionHydrationLane = 64,
1440514400
TransitionLanes = 4194176,
1440614401
RetryLanes = 62914560,
@@ -16364,14 +16359,14 @@ __DEV__ &&
1636416359
scheduleRoot: scheduleRoot,
1636516360
setRefreshHandler: setRefreshHandler,
1636616361
getCurrentFiber: getCurrentFiberForDevTools,
16367-
reconcilerVersion: "19.0.0-www-modern-0b724e9e9c-20240621"
16362+
reconcilerVersion: "19.0.0-www-modern-c21bcd627b-20240624"
1636816363
});
1636916364
})({
1637016365
findFiberByHostInstance: function () {
1637116366
return null;
1637216367
},
1637316368
bundleType: 1,
16374-
version: "19.0.0-www-modern-0b724e9e9c-20240621",
16369+
version: "19.0.0-www-modern-c21bcd627b-20240624",
1637516370
rendererPackageName: "react-art"
1637616371
});
1637716372
var ClippingRectangle = TYPES.CLIPPING_RECTANGLE,

0 commit comments

Comments
 (0)