Skip to content

Commit ae7639c

Browse files
AudyOdigaearon
authored andcommitted
Remove tests in ReactDOMComponent-test depending on internal API (#11337)
* Remove inputValueTracking from ReactDOMComponent-test dependency * prettier * use node._valueTracker and add some test cases to make sure that value being tracked * using Object.getOwnPropertyDescriptor to get the tracked value * move getValueTracker to each test case and use its corresponding prototype * remove tests and move the value tracker definition before React is imported * Delete these tests completely
1 parent 54051f9 commit ae7639c

File tree

1 file changed

+0
-24
lines changed

1 file changed

+0
-24
lines changed

packages/react-dom/src/__tests__/ReactDOMComponent-test.js

Lines changed: 0 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@ describe('ReactDOMComponent', () => {
1414
var ReactTestUtils;
1515
var ReactDOM;
1616
var ReactDOMServer;
17-
var inputValueTracking;
1817

1918
function normalizeCodeLocInfo(str) {
2019
return str && str.replace(/\(at .+?:\d+\)/g, '(at **)');
@@ -26,8 +25,6 @@ describe('ReactDOMComponent', () => {
2625
ReactDOM = require('react-dom');
2726
ReactDOMServer = require('react-dom/server');
2827
ReactTestUtils = require('react-dom/test-utils');
29-
// TODO: can we express this test with only public API?
30-
inputValueTracking = require('../client/inputValueTracking');
3128
});
3229

3330
describe('updateDOM', () => {
@@ -1174,27 +1171,6 @@ describe('ReactDOMComponent', () => {
11741171
);
11751172
});
11761173

1177-
it('should track input values', () => {
1178-
var container = document.createElement('div');
1179-
var inst = ReactDOM.render(
1180-
<input type="text" defaultValue="foo" />,
1181-
container,
1182-
);
1183-
1184-
var tracker = inputValueTracking._getTrackerFromNode(inst);
1185-
1186-
expect(tracker.getValue()).toEqual('foo');
1187-
});
1188-
1189-
it('should track textarea values', () => {
1190-
var container = document.createElement('div');
1191-
var inst = ReactDOM.render(<textarea defaultValue="foo" />, container);
1192-
1193-
var tracker = inputValueTracking._getTrackerFromNode(inst);
1194-
1195-
expect(tracker.getValue()).toEqual('foo');
1196-
});
1197-
11981174
it('should throw for children on void elements', () => {
11991175
class X extends React.Component {
12001176
render() {

0 commit comments

Comments
 (0)