Skip to content

Commit acaae63

Browse files
author
Sebastian Silbermann
committed
Fix crash running yarn flags --sort flag
1 parent 2e470a7 commit acaae63

File tree

1 file changed

+9
-5
lines changed

1 file changed

+9
-5
lines changed

scripts/flags/flags.js

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -318,11 +318,15 @@ for (const flag of allFlagsUniqueFlags) {
318318
let sorted = table;
319319
if (isDiff || argv.sort) {
320320
const sortChannel = argToHeader(isDiff ? argv.diff[0] : argv.sort);
321-
sorted = Object.fromEntries(
322-
Object.entries(table).sort(([, rowA], [, rowB]) =>
323-
rowB[sortChannel].toString().localeCompare(rowA[sortChannel])
324-
)
325-
);
321+
const sortBy =
322+
sortChannel === 'flag'
323+
? ([flagA], [flagB]) => {
324+
return flagA.localeCompare(flagB);
325+
}
326+
: ([, rowA], [, rowB]) => {
327+
return rowB[sortChannel].toString().localeCompare(rowA[sortChannel]);
328+
};
329+
sorted = Object.fromEntries(Object.entries(table).sort(sortBy));
326330
}
327331

328332
if (argv.csv) {

0 commit comments

Comments
 (0)