Run Flow per renderer

Author: gaearon

scripts/flow/createFlowConfigs.js

@@ -2,6 +2,7 @@
 
 const chalk = require('chalk');
 const fs = require('fs');
+const {typedRenderers} = require('./typedRenderers');
 
 const config = fs.readFileSync(__dirname + '/config/flowconfig');
 
@@ -17,7 +18,7 @@ function writeConfig(folder) {
   const configFile = folder + '/.flowconfig';
   let oldConfig;
   try {
-    oldConfig = fs.readFileSync(configFile);
+    oldConfig = fs.readFileSync(configFile).toString();
   } catch (err) {
     oldConfig = null;
   }
@@ -26,18 +27,15 @@ ${disclaimer}
 ${config}
 ${disclaimer}
 `.trim();
+
   if (newConfig !== oldConfig) {
     fs.writeFileSync(configFile, newConfig);
+    console.log(chalk.dim('Wrote a Flow config to ' + configFile));
   }
 }
 
 // Write multiple configs in different folders
 // so that we can run those checks in parallel if we want.
-writeConfig(__dirname + '/dom');
-writeConfig(__dirname + '/fabric');
-writeConfig(__dirname + '/native');
-writeConfig(__dirname + '/test');
-
-console.log(
-  chalk.dim('Wrote the Flow configurations to ./scripts/flow/*/.flowconfig'),
-);
+typedRenderers.forEach(renderer => {
+  writeConfig(__dirname + '/' + renderer);
+});

scripts/flow/runFlow.js

@@ -0,0 +1,38 @@
+'use strict';
+
+const chalk = require('chalk');
+const spawn = require('child_process').spawn;
+const extension = process.platform === 'win32' ? '.cmd' : '';
+
+require('./createFlowConfigs');
+
+async function runFlow(renderer, args) {
+  return new Promise(resolve => {
+    console.log(
+      'Running Flow for the ' + chalk.cyan(renderer) + ' renderer...',
+    );
+    console.log();
+    spawn('../../../node_modules/.bin/flow' + extension, args, {
+      // Allow colors to pass through:
+      stdio: 'inherit',
+      // Use a specific renderer config:
+      cwd: process.cwd() + '/scripts/flow/' + renderer + '/',
+    }).on('close', function(code) {
+      if (code !== 0) {
+        console.error(
+          'Flow failed for the ' + chalk.red(renderer) + ' renderer',
+        );
+        console.log();
+        process.exit(code);
+      } else {
+        console.log(
+          'Flow passed for the ' + chalk.green(renderer) + ' renderer',
+        );
+        console.log();
+        resolve();
+      }
+    });
+  });
+}
+
+module.exports = runFlow;

scripts/flow/typedRenderers.js

@@ -0,0 +1,3 @@
+'use strict';
+
+exports.typedRenderers = ['dom', 'fabric', 'native', 'test'];

scripts/tasks/flow-ci.js

@@ -7,25 +7,17 @@
 
 'use strict';
 
-require('../flow/createFlowConfigs');
-
-const spawn = require('child_process').spawn;
-
-const extension = process.platform === 'win32' ? '.cmd' : '';
+process.on('unhandledRejection', err => {
+  throw err;
+});
 
-// This script forces a complete check.
-// Use it for the CI.
+const runFlow = require('../flow/runFlow');
+const {typedRenderers} = require('../flow/typedRenderers');
 
-spawn('../../../node_modules/.bin/flow' + extension, ['check', '.'], {
-  // Allow colors to pass through
-  stdio: 'inherit',
-  cwd: process.cwd() + '/scripts/flow/dom/',
-}).on('close', function(code) {
-  if (code !== 0) {
-    console.error('Flow failed');
-  } else {
-    console.log('Flow passed');
+async function checkAll() {
+  for (let renderer of typedRenderers) {
+    await runFlow(renderer, ['check']);
   }
+}
 
-  process.exit(code);
-});
+checkAll();

scripts/tasks/flow.js

@@ -7,25 +7,26 @@
 
 'use strict';
 
-require('../flow/createFlowConfigs');
-
-const spawn = require('child_process').spawn;
+process.on('unhandledRejection', err => {
+  throw err;
+});
 
-const extension = process.platform === 'win32' ? '.cmd' : '';
+const runFlow = require('../flow/runFlow');
+const {typedRenderers} = require('../flow/typedRenderers');
 
 // This script is using `flow status` for a quick check with a server.
 // Use it for local development.
 
-spawn('../../../node_modules/.bin/flow' + extension, ['status', '.'], {
-  // Allow colors to pass through
-  stdio: 'inherit',
-  cwd: process.cwd() + '/scripts/flow/dom/',
-}).on('close', function(code) {
-  if (code !== 0) {
-    console.error('Flow failed');
-  } else {
-    console.log('Flow passed');
-  }
+const primaryRenderer = process.argv[2];
+if (typedRenderers.indexOf(primaryRenderer) === -1) {
+  console.error(
+    'You need to pass a primary renderer to yarn flow. For example:'
+  );
+  typedRenderers.forEach(renderer => {
+    console.log('  * yarn flow ' + renderer);
+  });
+  console.log();
+  process.exit(1);
+}
 
-  process.exit(code);
-});
+runFlow(primaryRenderer, ['status']);