[compiler] Reordering of logical expressions

ghstack-source-id: ad484f9
Pull Request resolved: #30678

Author: mvitousek

compiler/packages/babel-plugin-react-compiler/src/HIR/BuildHIR.ts

@@ -2847,6 +2847,21 @@ function isReorderableExpression(
         allowLocalIdentifiers,
       );
     }
+    case 'LogicalExpression': {
+      const logical = expr as NodePath<t.LogicalExpression>;
+      return (
+        isReorderableExpression(
+          builder,
+          logical.get('left'),
+          allowLocalIdentifiers,
+        ) &&
+        isReorderableExpression(
+          builder,
+          logical.get('right'),
+          allowLocalIdentifiers,
+        )
+      );
+    }
     case 'ConditionalExpression': {
       const conditional = expr as NodePath<t.ConditionalExpression>;
       return (

compiler/packages/babel-plugin-react-compiler/src/__tests__/fixtures/compiler/logical-reorder.flow.expect.md

@@ -0,0 +1,39 @@
+
+## Input
+
+```javascript
+//@flow
+
+const foo = undefined;
+
+component C(...{scope = foo ?? null}: any) {
+  return scope;
+}
+
+export const FIXTURE_ENTRYPOINT = {
+  fn: C,
+  params: [{scope: undefined}],
+};
+
+```
+
+## Code
+
+```javascript
+const foo = undefined;
+
+function C(t0) {
+  const { scope: t1 } = t0;
+  const scope = t1 === undefined ? (foo ?? null) : t1;
+  return scope;
+}
+
+export const FIXTURE_ENTRYPOINT = {
+  fn: C,
+  params: [{ scope: undefined }],
+};
+
+```
+      
+### Eval output
+(kind: ok) null

compiler/packages/babel-plugin-react-compiler/src/__tests__/fixtures/compiler/logical-reorder.flow.js

@@ -0,0 +1,12 @@
+//@flow
+
+const foo = undefined;
+
+component C(...{scope = foo ?? null}: any) {
+  return scope;
+}
+
+export const FIXTURE_ENTRYPOINT = {
+  fn: C,
+  params: [{scope: undefined}],
+};