Skip to content

Commit 7bfb304

Browse files
rickhanloniirickhanlonii
committed
Remove createRootStrictEffectsByDefault flag (#28102)
There's no need to separate strict mode from strict effects mode any more. I didn't clean up the `StrictEffectMode` fiber flag, because it's used to prevent strict effects in legacy mode. I could replace those checks with `LegacyMode` checks, but when we remove legacy mode, we can remove that flag and condense them into one StrictMode flag away. DiffTrain build for [3d1da1f](3d1da1f)
1 parent 9628430 commit 7bfb304

11 files changed

+21
-29
lines changed

‎compiled/facebook-www/REVISION‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
a1433ca0bacff76f720ffec9a0020f56e8c9ffed
1+
3d1da1f9ab7d54984c096e6a04c8729f3a50fd8a

‎compiled/facebook-www/React-prod.classic.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -572,4 +572,4 @@ exports.useSyncExternalStore = function (
572572
exports.useTransition = function () {
573573
return ReactCurrentDispatcher.current.useTransition();
574574
};
575-
exports.version = "18.3.0-www-classic-8dbe57fc";
575+
exports.version = "18.3.0-www-classic-89ae6c5e";

‎compiled/facebook-www/ReactART-dev.classic.js‎

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ if (__DEV__) {
6666
return self;
6767
}
6868

69-
var ReactVersion = "18.3.0-www-classic-ffbafb55";
69+
var ReactVersion = "18.3.0-www-classic-e82d96aa";
7070

7171
var LegacyRoot = 0;
7272
var ConcurrentRoot = 1;
@@ -192,7 +192,6 @@ if (__DEV__) {
192192
var enableProfilerNestedUpdatePhase = true;
193193
var enableProfilerNestedUpdateScheduledHook =
194194
dynamicFeatureFlags.enableProfilerNestedUpdateScheduledHook;
195-
var createRootStrictEffectsByDefault = false;
196195

197196
var enableSchedulingProfiler = dynamicFeatureFlags.enableSchedulingProfiler;
198197

@@ -29281,7 +29280,7 @@ if (__DEV__) {
2928129280
if (tag === ConcurrentRoot) {
2928229281
mode = ConcurrentMode;
2928329282

29284-
if (isStrictMode === true || createRootStrictEffectsByDefault) {
29283+
if (isStrictMode === true) {
2928529284
mode |= StrictLegacyMode | StrictEffectsMode;
2928629285
}
2928729286

‎compiled/facebook-www/ReactART-dev.modern.js‎

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ if (__DEV__) {
6666
return self;
6767
}
6868

69-
var ReactVersion = "18.3.0-www-modern-c768d9b6";
69+
var ReactVersion = "18.3.0-www-modern-f1f6b170";
7070

7171
var LegacyRoot = 0;
7272
var ConcurrentRoot = 1;
@@ -192,7 +192,6 @@ if (__DEV__) {
192192
var enableProfilerNestedUpdatePhase = true;
193193
var enableProfilerNestedUpdateScheduledHook =
194194
dynamicFeatureFlags.enableProfilerNestedUpdateScheduledHook;
195-
var createRootStrictEffectsByDefault = false;
196195

197196
var enableSchedulingProfiler = dynamicFeatureFlags.enableSchedulingProfiler;
198197

@@ -28916,7 +28915,7 @@ if (__DEV__) {
2891628915
if (tag === ConcurrentRoot) {
2891728916
mode = ConcurrentMode;
2891828917

28919-
if (isStrictMode === true || createRootStrictEffectsByDefault) {
28918+
if (isStrictMode === true) {
2892028919
mode |= StrictLegacyMode | StrictEffectsMode;
2892128920
}
2892228921

‎compiled/facebook-www/ReactDOM-dev.classic.js‎

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -157,7 +157,6 @@ if (__DEV__) {
157157
var enableProfilerNestedUpdatePhase = true;
158158
var enableProfilerNestedUpdateScheduledHook =
159159
dynamicFeatureFlags.enableProfilerNestedUpdateScheduledHook;
160-
var createRootStrictEffectsByDefault = false;
161160
var enableClientRenderFallbackOnTextMismatch = false;
162161

163162
var enableSchedulingProfiler = dynamicFeatureFlags.enableSchedulingProfiler;
@@ -35172,7 +35171,7 @@ if (__DEV__) {
3517235171
if (tag === ConcurrentRoot) {
3517335172
mode = ConcurrentMode;
3517435173

35175-
if (isStrictMode === true || createRootStrictEffectsByDefault) {
35174+
if (isStrictMode === true) {
3517635175
mode |= StrictLegacyMode | StrictEffectsMode;
3517735176
}
3517835177

@@ -35754,7 +35753,7 @@ if (__DEV__) {
3575435753
return root;
3575535754
}
3575635755

35757-
var ReactVersion = "18.3.0-www-classic-3799de5b";
35756+
var ReactVersion = "18.3.0-www-classic-8c1ce378";
3575835757

3575935758
function createPortal$1(
3576035759
children,

‎compiled/facebook-www/ReactDOM-dev.modern.js‎

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -143,7 +143,6 @@ if (__DEV__) {
143143
var enableProfilerNestedUpdatePhase = true;
144144
var enableProfilerNestedUpdateScheduledHook =
145145
dynamicFeatureFlags.enableProfilerNestedUpdateScheduledHook;
146-
var createRootStrictEffectsByDefault = false;
147146
var enableClientRenderFallbackOnTextMismatch = false;
148147

149148
var enableSchedulingProfiler = dynamicFeatureFlags.enableSchedulingProfiler;
@@ -34993,7 +34992,7 @@ if (__DEV__) {
3499334992
if (tag === ConcurrentRoot) {
3499434993
mode = ConcurrentMode;
3499534994

34996-
if (isStrictMode === true || createRootStrictEffectsByDefault) {
34995+
if (isStrictMode === true) {
3499734996
mode |= StrictLegacyMode | StrictEffectsMode;
3499834997
}
3499934998

@@ -35575,7 +35574,7 @@ if (__DEV__) {
3557535574
return root;
3557635575
}
3557735576

35578-
var ReactVersion = "18.3.0-www-modern-41422569";
35577+
var ReactVersion = "18.3.0-www-modern-c82c01ca";
3557935578

3558035579
function createPortal$1(
3558135580
children,

‎compiled/facebook-www/ReactDOM-profiling.modern.js‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17440,7 +17440,7 @@ Internals.Events = [
1744017440
var devToolsConfig$jscomp$inline_1867 = {
1744117441
findFiberByHostInstance: getClosestInstanceFromNode,
1744217442
bundleType: 0,
17443-
version: "18.3.0-www-modern-c768d9b6",
17443+
version: "18.3.0-www-modern-f1f6b170",
1744417444
rendererPackageName: "react-dom"
1744517445
};
1744617446
(function (internals) {
@@ -17485,7 +17485,7 @@ var devToolsConfig$jscomp$inline_1867 = {
1748517485
scheduleRoot: null,
1748617486
setRefreshHandler: null,
1748717487
getCurrentFiber: null,
17488-
reconcilerVersion: "18.3.0-www-modern-c768d9b6"
17488+
reconcilerVersion: "18.3.0-www-modern-f1f6b170"
1748917489
});
1749017490
exports.__SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED = Internals;
1749117491
exports.createPortal = function (children, container) {
@@ -17750,7 +17750,7 @@ exports.useFormStatus = function () {
1775017750
return ReactCurrentDispatcher$2.current.useHostTransitionStatus();
1775117751
throw Error(formatProdErrorMessage(248));
1775217752
};
17753-
exports.version = "18.3.0-www-modern-c768d9b6";
17753+
exports.version = "18.3.0-www-modern-f1f6b170";
1775417754
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
1775517755
"function" ===
1775617756
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

‎compiled/facebook-www/ReactDOMTesting-dev.classic.js‎

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -149,7 +149,6 @@ if (__DEV__) {
149149
var enableProfilerNestedUpdatePhase = true;
150150
var enableProfilerNestedUpdateScheduledHook =
151151
dynamicFeatureFlags.enableProfilerNestedUpdateScheduledHook;
152-
var createRootStrictEffectsByDefault = false;
153152
var enableClientRenderFallbackOnTextMismatch = false;
154153

155154
var enableSchedulingProfiler = dynamicFeatureFlags.enableSchedulingProfiler;
@@ -35796,7 +35795,7 @@ if (__DEV__) {
3579635795
if (tag === ConcurrentRoot) {
3579735796
mode = ConcurrentMode;
3579835797

35799-
if (isStrictMode === true || createRootStrictEffectsByDefault) {
35798+
if (isStrictMode === true) {
3580035799
mode |= StrictLegacyMode | StrictEffectsMode;
3580135800
}
3580235801

@@ -36378,7 +36377,7 @@ if (__DEV__) {
3637836377
return root;
3637936378
}
3638036379

36381-
var ReactVersion = "18.3.0-www-classic-85d94c0f";
36380+
var ReactVersion = "18.3.0-www-classic-11bc03a7";
3638236381

3638336382
function createPortal$1(
3638436383
children,

‎compiled/facebook-www/ReactDOMTesting-dev.modern.js‎

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -135,7 +135,6 @@ if (__DEV__) {
135135
var enableProfilerNestedUpdatePhase = true;
136136
var enableProfilerNestedUpdateScheduledHook =
137137
dynamicFeatureFlags.enableProfilerNestedUpdateScheduledHook;
138-
var createRootStrictEffectsByDefault = false;
139138
var enableClientRenderFallbackOnTextMismatch = false;
140139

141140
var enableSchedulingProfiler = dynamicFeatureFlags.enableSchedulingProfiler;
@@ -35617,7 +35616,7 @@ if (__DEV__) {
3561735616
if (tag === ConcurrentRoot) {
3561835617
mode = ConcurrentMode;
3561935618

35620-
if (isStrictMode === true || createRootStrictEffectsByDefault) {
35619+
if (isStrictMode === true) {
3562135620
mode |= StrictLegacyMode | StrictEffectsMode;
3562235621
}
3562335622

@@ -36199,7 +36198,7 @@ if (__DEV__) {
3619936198
return root;
3620036199
}
3620136200

36202-
var ReactVersion = "18.3.0-www-modern-24f46394";
36201+
var ReactVersion = "18.3.0-www-modern-895ad972";
3620336202

3620436203
function createPortal$1(
3620536204
children,

‎compiled/facebook-www/ReactTestRenderer-dev.classic.js‎

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -140,7 +140,6 @@ if (__DEV__) {
140140
var enableProfilerNestedUpdatePhase = true;
141141
var syncLaneExpirationMs = 250;
142142
var transitionLaneExpirationMs = 5000;
143-
var createRootStrictEffectsByDefault = false;
144143
var enableLazyContextPropagation = false;
145144
var enableLegacyHidden = false;
146145
var enableAsyncActions = true;
@@ -25641,7 +25640,7 @@ if (__DEV__) {
2564125640
if (tag === ConcurrentRoot) {
2564225641
mode = ConcurrentMode;
2564325642

25644-
if (isStrictMode === true || createRootStrictEffectsByDefault) {
25643+
if (isStrictMode === true) {
2564525644
mode |= StrictLegacyMode | StrictEffectsMode;
2564625645
}
2564725646

@@ -26078,7 +26077,7 @@ if (__DEV__) {
2607826077
return root;
2607926078
}
2608026079

26081-
var ReactVersion = "18.3.0-www-classic-8dbe57fc";
26080+
var ReactVersion = "18.3.0-www-classic-89ae6c5e";
2608226081

2608326082
// Might add PROFILE later.
2608426083

0 commit comments

Comments
 (0)