Skip to content

Commit 70b01d0

Browse files
noahlemennoahlemen
committed
Cleanup unused unstable_startTransition, unstable_useTransition, unstable_useDeferredValue exports from fb packages (#27056)
## Summary came across these TODOs – an internal grep indicated that remaining callsites have been cleaned up, so these can now be removed. ## How did you test this change? ``` yarn flow dom-browser yarn test ``` DiffTrain build for commit e91142d.
1 parent 9a8a80b commit 70b01d0

File tree

7 files changed

+50
-65
lines changed

7 files changed

+50
-65
lines changed

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react-test-renderer/cjs/ReactTestRenderer-dev.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23982,7 +23982,7 @@ function createFiberRoot(
2398223982
return root;
2398323983
}
2398423984

23985-
var ReactVersion = "18.3.0-canary-7118f5dd7-20230705";
23985+
var ReactVersion = "18.3.0-canary-e91142dd6-20230705";
2398623986

2398723987
// Might add PROFILE later.
2398823988

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react-test-renderer/cjs/ReactTestRenderer-prod.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8630,7 +8630,7 @@ var devToolsConfig$jscomp$inline_1032 = {
86308630
throw Error("TestRenderer does not support findFiberByHostInstance()");
86318631
},
86328632
bundleType: 0,
8633-
version: "18.3.0-canary-7118f5dd7-20230705",
8633+
version: "18.3.0-canary-e91142dd6-20230705",
86348634
rendererPackageName: "react-test-renderer"
86358635
};
86368636
var internals$jscomp$inline_1231 = {
@@ -8661,7 +8661,7 @@ var internals$jscomp$inline_1231 = {
86618661
scheduleRoot: null,
86628662
setRefreshHandler: null,
86638663
getCurrentFiber: null,
8664-
reconcilerVersion: "18.3.0-canary-7118f5dd7-20230705"
8664+
reconcilerVersion: "18.3.0-canary-e91142dd6-20230705"
86658665
};
86668666
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
86678667
var hook$jscomp$inline_1232 = __REACT_DEVTOOLS_GLOBAL_HOOK__;

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react-test-renderer/cjs/ReactTestRenderer-profiling.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9056,7 +9056,7 @@ var devToolsConfig$jscomp$inline_1074 = {
90569056
throw Error("TestRenderer does not support findFiberByHostInstance()");
90579057
},
90589058
bundleType: 0,
9059-
version: "18.3.0-canary-7118f5dd7-20230705",
9059+
version: "18.3.0-canary-e91142dd6-20230705",
90609060
rendererPackageName: "react-test-renderer"
90619061
};
90629062
var internals$jscomp$inline_1272 = {
@@ -9087,7 +9087,7 @@ var internals$jscomp$inline_1272 = {
90879087
scheduleRoot: null,
90889088
setRefreshHandler: null,
90899089
getCurrentFiber: null,
9090-
reconcilerVersion: "18.3.0-canary-7118f5dd7-20230705"
9090+
reconcilerVersion: "18.3.0-canary-e91142dd6-20230705"
90919091
};
90929092
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
90939093
var hook$jscomp$inline_1273 = __REACT_DEVTOOLS_GLOBAL_HOOK__;

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/cjs/React-dev.js‎

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<85cf0b54e8f0b417c4ef6e8f35c5a677>>
10+
* @generated SignedSource<<e07addc76261adf5c9844f571089b66c>>
1111
*/
1212

1313
'use strict';
@@ -27,7 +27,7 @@ if (
2727
}
2828
"use strict";
2929

30-
var ReactVersion = "18.3.0-canary-7118f5dd7-20230705";
30+
var ReactVersion = "18.3.0-canary-e91142dd6-20230705";
3131

3232
// ATTENTION
3333
// When adding new symbols to this file,
@@ -3928,11 +3928,8 @@ exports.unstable_TracingMarker = REACT_TRACING_MARKER_TYPE;
39283928
exports.unstable_act = act;
39293929
exports.unstable_getCacheForType = getCacheForType;
39303930
exports.unstable_getCacheSignal = getCacheSignal;
3931-
exports.unstable_startTransition = startTransition;
39323931
exports.unstable_useCacheRefresh = useCacheRefresh;
3933-
exports.unstable_useDeferredValue = useDeferredValue;
39343932
exports.unstable_useMemoCache = useMemoCache;
3935-
exports.unstable_useTransition = useTransition;
39363933
exports.use = use;
39373934
exports.useCallback = useCallback;
39383935
exports.useContext = useContext;

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/cjs/React-prod.js‎

Lines changed: 21 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<53c40bb7dda9ed688253fda038bc98ac>>
10+
* @generated SignedSource<<c874b3507aeda09a93133667e1fcecd7>>
1111
*/
1212

1313
"use strict";
@@ -280,32 +280,17 @@ function createCacheRoot() {
280280
function createCacheNode() {
281281
return { s: 0, v: void 0, o: null, p: null };
282282
}
283-
var ReactCurrentDispatcher = { current: null };
284-
function useTransition() {
285-
return ReactCurrentDispatcher.current.useTransition();
286-
}
287-
function useDeferredValue(value) {
288-
return ReactCurrentDispatcher.current.useDeferredValue(value);
289-
}
290-
var ReactCurrentBatchConfig = { transition: null },
283+
var ReactCurrentDispatcher = { current: null },
284+
ReactCurrentBatchConfig = { transition: null },
291285
ReactSharedInternals = {
292286
ReactCurrentDispatcher: ReactCurrentDispatcher,
293287
ReactCurrentCache: ReactCurrentCache,
294288
ReactCurrentBatchConfig: ReactCurrentBatchConfig,
295289
ReactCurrentOwner: ReactCurrentOwner$1,
296290
ContextRegistry: {}
297291
},
298-
ContextRegistry = ReactSharedInternals.ContextRegistry;
299-
function startTransition(scope) {
300-
var prevTransition = ReactCurrentBatchConfig.transition;
301-
ReactCurrentBatchConfig.transition = {};
302-
try {
303-
scope();
304-
} finally {
305-
ReactCurrentBatchConfig.transition = prevTransition;
306-
}
307-
}
308-
var ReactCurrentOwner = ReactSharedInternals.ReactCurrentOwner,
292+
ContextRegistry = ReactSharedInternals.ContextRegistry,
293+
ReactCurrentOwner = ReactSharedInternals.ReactCurrentOwner,
309294
RESERVED_PROPS = { key: !0, ref: !0, __self: !0, __source: !0 };
310295
function jsx$1(type, config, maybeKey) {
311296
var propName,
@@ -537,7 +522,15 @@ exports.memo = function (type, compare) {
537522
compare: void 0 === compare ? null : compare
538523
};
539524
};
540-
exports.startTransition = startTransition;
525+
exports.startTransition = function (scope) {
526+
var prevTransition = ReactCurrentBatchConfig.transition;
527+
ReactCurrentBatchConfig.transition = {};
528+
try {
529+
scope();
530+
} finally {
531+
ReactCurrentBatchConfig.transition = prevTransition;
532+
}
533+
};
541534
exports.unstable_Cache = REACT_CACHE_TYPE;
542535
exports.unstable_DebugTracingMode = REACT_DEBUG_TRACING_MODE_TYPE;
543536
exports.unstable_LegacyHidden = REACT_LEGACY_HIDDEN_TYPE;
@@ -564,15 +557,12 @@ exports.unstable_getCacheSignal = function () {
564557
),
565558
dispatcher.signal);
566559
};
567-
exports.unstable_startTransition = startTransition;
568560
exports.unstable_useCacheRefresh = function () {
569561
return ReactCurrentDispatcher.current.useCacheRefresh();
570562
};
571-
exports.unstable_useDeferredValue = useDeferredValue;
572563
exports.unstable_useMemoCache = function (size) {
573564
return ReactCurrentDispatcher.current.useMemoCache(size);
574565
};
575-
exports.unstable_useTransition = useTransition;
576566
exports.use = function (usable) {
577567
return ReactCurrentDispatcher.current.use(usable);
578568
};
@@ -583,7 +573,9 @@ exports.useContext = function (Context) {
583573
return ReactCurrentDispatcher.current.useContext(Context);
584574
};
585575
exports.useDebugValue = function () {};
586-
exports.useDeferredValue = useDeferredValue;
576+
exports.useDeferredValue = function (value) {
577+
return ReactCurrentDispatcher.current.useDeferredValue(value);
578+
};
587579
exports.useEffect = function (create, deps) {
588580
return ReactCurrentDispatcher.current.useEffect(create, deps);
589581
};
@@ -622,5 +614,7 @@ exports.useSyncExternalStore = function (
622614
getServerSnapshot
623615
);
624616
};
625-
exports.useTransition = useTransition;
626-
exports.version = "18.3.0-canary-7118f5dd7-20230705";
617+
exports.useTransition = function () {
618+
return ReactCurrentDispatcher.current.useTransition();
619+
};
620+
exports.version = "18.3.0-canary-e91142dd6-20230705";

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/cjs/React-profiling.js‎

Lines changed: 21 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<23eeabb4d0c92eafb27fe3cdffcaf299>>
10+
* @generated SignedSource<<70baf3b541539dca5899f9c542f152f7>>
1111
*/
1212

1313

@@ -258,32 +258,17 @@ function createCacheRoot() {
258258
function createCacheNode() {
259259
return { s: 0, v: void 0, o: null, p: null };
260260
}
261-
var ReactCurrentDispatcher = { current: null };
262-
function useTransition() {
263-
return ReactCurrentDispatcher.current.useTransition();
264-
}
265-
function useDeferredValue(value) {
266-
return ReactCurrentDispatcher.current.useDeferredValue(value);
267-
}
268-
var ReactCurrentBatchConfig = { transition: null },
261+
var ReactCurrentDispatcher = { current: null },
262+
ReactCurrentBatchConfig = { transition: null },
269263
ReactSharedInternals = {
270264
ReactCurrentDispatcher: ReactCurrentDispatcher,
271265
ReactCurrentCache: ReactCurrentCache,
272266
ReactCurrentBatchConfig: ReactCurrentBatchConfig,
273267
ReactCurrentOwner: ReactCurrentOwner$1,
274268
ContextRegistry: {}
275269
},
276-
ContextRegistry = ReactSharedInternals.ContextRegistry;
277-
function startTransition(scope) {
278-
var prevTransition = ReactCurrentBatchConfig.transition;
279-
ReactCurrentBatchConfig.transition = {};
280-
try {
281-
scope();
282-
} finally {
283-
ReactCurrentBatchConfig.transition = prevTransition;
284-
}
285-
}
286-
var ReactCurrentOwner = ReactSharedInternals.ReactCurrentOwner,
270+
ContextRegistry = ReactSharedInternals.ContextRegistry,
271+
ReactCurrentOwner = ReactSharedInternals.ReactCurrentOwner,
287272
RESERVED_PROPS = { key: !0, ref: !0, __self: !0, __source: !0 };
288273
function jsx$1(type, config, maybeKey) {
289274
var propName,
@@ -541,7 +526,15 @@ exports.memo = function (type, compare) {
541526
compare: void 0 === compare ? null : compare
542527
};
543528
};
544-
exports.startTransition = startTransition;
529+
exports.startTransition = function (scope) {
530+
var prevTransition = ReactCurrentBatchConfig.transition;
531+
ReactCurrentBatchConfig.transition = {};
532+
try {
533+
scope();
534+
} finally {
535+
ReactCurrentBatchConfig.transition = prevTransition;
536+
}
537+
};
545538
exports.unstable_Cache = REACT_CACHE_TYPE;
546539
exports.unstable_DebugTracingMode = REACT_DEBUG_TRACING_MODE_TYPE;
547540
exports.unstable_LegacyHidden = REACT_LEGACY_HIDDEN_TYPE;
@@ -567,15 +560,12 @@ exports.unstable_getCacheSignal = function () {
567560
),
568561
dispatcher.signal);
569562
};
570-
exports.unstable_startTransition = startTransition;
571563
exports.unstable_useCacheRefresh = function () {
572564
return ReactCurrentDispatcher.current.useCacheRefresh();
573565
};
574-
exports.unstable_useDeferredValue = useDeferredValue;
575566
exports.unstable_useMemoCache = function (size) {
576567
return ReactCurrentDispatcher.current.useMemoCache(size);
577568
};
578-
exports.unstable_useTransition = useTransition;
579569
exports.use = function (usable) {
580570
return ReactCurrentDispatcher.current.use(usable);
581571
};
@@ -586,7 +576,9 @@ exports.useContext = function (Context) {
586576
return ReactCurrentDispatcher.current.useContext(Context);
587577
};
588578
exports.useDebugValue = function () {};
589-
exports.useDeferredValue = useDeferredValue;
579+
exports.useDeferredValue = function (value) {
580+
return ReactCurrentDispatcher.current.useDeferredValue(value);
581+
};
590582
exports.useEffect = function (create, deps) {
591583
return ReactCurrentDispatcher.current.useEffect(create, deps);
592584
};
@@ -625,8 +617,10 @@ exports.useSyncExternalStore = function (
625617
getServerSnapshot
626618
);
627619
};
628-
exports.useTransition = useTransition;
629-
exports.version = "18.3.0-canary-7118f5dd7-20230705";
620+
exports.useTransition = function () {
621+
return ReactCurrentDispatcher.current.useTransition();
622+
};
623+
exports.version = "18.3.0-canary-e91142dd6-20230705";
630624

631625
/* global __REACT_DEVTOOLS_GLOBAL_HOOK__ */
632626
if (

‎compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/REVISION‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
7118f5dd7bf5f1c44d0d2944ef8ad58e423909ad
1+
e91142dd69b0454e0d4e934c55dd541344fe32ca

0 commit comments

Comments
 (0)