Skip to content

Commit 6a298b2

Browse files
committed
Make prerendering always non-blocking with fix (#31452)
We've previously failed to land this change due to some internal apps seeing infinite render loops due to external store state updates during render. It turns out that since the `renderWasConcurrent` var was moved into the do block, the sync render triggered from the external store check was stuck with a `RootSuspended` `exitStatus`. So this is not unique to sibling prerendering but more generally related to how we handle update to a sync external store during render. We've tested this build against local repros which now render without crashes. We will try to add a unit test to cover the scenario as well. --------- Co-authored-by: Andrew Clark <[email protected]> Co-authored-by: Rick Hanlon <[email protected]> DiffTrain build for [989af12](989af12)
1 parent db36607 commit 6a298b2

34 files changed

+6540
-6138
lines changed

compiled/facebook-www/REVISION

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
682a103cde99a3091850d1c27de8846b5d14e803
1+
989af12f72080c17db03ead91d99b6394a215564
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
682a103cde99a3091850d1c27de8846b5d14e803
1+
989af12f72080c17db03ead91d99b6394a215564

compiled/facebook-www/React-dev.classic.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1819,7 +1819,7 @@ __DEV__ &&
18191819
exports.useTransition = function () {
18201820
return resolveDispatcher().useTransition();
18211821
};
1822-
exports.version = "19.0.0-www-classic-682a103c-20241107";
1822+
exports.version = "19.0.0-www-classic-989af12f-20241108";
18231823
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
18241824
"function" ===
18251825
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

compiled/facebook-www/React-dev.modern.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1819,7 +1819,7 @@ __DEV__ &&
18191819
exports.useTransition = function () {
18201820
return resolveDispatcher().useTransition();
18211821
};
1822-
exports.version = "19.0.0-www-modern-682a103c-20241107";
1822+
exports.version = "19.0.0-www-modern-989af12f-20241108";
18231823
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
18241824
"function" ===
18251825
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

compiled/facebook-www/React-prod.classic.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -619,4 +619,4 @@ exports.useSyncExternalStore = function (
619619
exports.useTransition = function () {
620620
return ReactSharedInternals.H.useTransition();
621621
};
622-
exports.version = "19.0.0-www-classic-682a103c-20241107";
622+
exports.version = "19.0.0-www-classic-989af12f-20241108";

compiled/facebook-www/React-prod.modern.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -619,4 +619,4 @@ exports.useSyncExternalStore = function (
619619
exports.useTransition = function () {
620620
return ReactSharedInternals.H.useTransition();
621621
};
622-
exports.version = "19.0.0-www-modern-682a103c-20241107";
622+
exports.version = "19.0.0-www-modern-989af12f-20241108";

compiled/facebook-www/React-profiling.classic.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -623,7 +623,7 @@ exports.useSyncExternalStore = function (
623623
exports.useTransition = function () {
624624
return ReactSharedInternals.H.useTransition();
625625
};
626-
exports.version = "19.0.0-www-classic-682a103c-20241107";
626+
exports.version = "19.0.0-www-classic-989af12f-20241108";
627627
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
628628
"function" ===
629629
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

compiled/facebook-www/React-profiling.modern.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -623,7 +623,7 @@ exports.useSyncExternalStore = function (
623623
exports.useTransition = function () {
624624
return ReactSharedInternals.H.useTransition();
625625
};
626-
exports.version = "19.0.0-www-modern-682a103c-20241107";
626+
exports.version = "19.0.0-www-modern-989af12f-20241108";
627627
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
628628
"function" ===
629629
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

0 commit comments

Comments
 (0)