Skip to content

Commit 6677f67

Browse files
author
Brian Vaughn
committed
Added TODO comment to revisit shouldSetTextContent()
1 parent abacd2f commit 6677f67

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

src/renderers/native/ReactNativeFiber.js

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -304,6 +304,12 @@ const NativeRenderer = ReactFiberReconciler({
304304
scheduleDeferredCallback: global.requestIdleCallback,
305305

306306
shouldSetTextContent(props : Props) : boolean {
307+
// TODO (bvaughn) Revisit this decision.
308+
// Always returning false simplifies the createInstance() implementation,
309+
// But creates an additional child Fiber for raw text children.
310+
// No additional native views are created though.
311+
// It's not clear to me which is better so I'm deferring for now.
312+
// More context @ github.com/facebook/react/pull/8560#discussion_r92111303
307313
return false;
308314
},
309315

0 commit comments

Comments
 (0)