Skip to content

Commit 6070bf0

Browse files
author
Kunuk Nykjaer
committed
resolve merge conflict
2 parents aacee9b + 9def56e commit 6070bf0

File tree

243 files changed

+9005
-10679
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

243 files changed

+9005
-10679
lines changed

.eslintrc.js

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,10 @@ const OFF = 0;
99
const ERROR = 2;
1010

1111
module.exports = {
12-
extends: 'fbjs',
12+
extends: [
13+
'fbjs',
14+
'prettier'
15+
],
1316

1417
// Stop ESLint from looking for a configuration file in parent folders
1518
root: true,
@@ -30,7 +33,6 @@ module.exports = {
3033
rules: {
3134
'accessor-pairs': OFF,
3235
'brace-style': [ERROR, '1tbs'],
33-
'comma-dangle': [ERROR, 'always-multiline'],
3436
'consistent-return': OFF,
3537
'dot-location': [ERROR, 'property'],
3638
// We use console['error']() as a signal to not transform it:

.github/ISSUE_TEMPLATE.md

Lines changed: 3 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,4 @@
1-
<!--
2-
Note: if the issue is about documentation or the website, please file it at:
3-
https://github.com/reactjs/reactjs.org/issues/new
4-
-->
1+
👉 Please follow one of these issue templates:
2+
- https://github.com/facebook/react/issues/new/choose
53

6-
**Do you want to request a *feature* or report a *bug*?**
7-
8-
**What is the current behavior?**
9-
10-
**If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem. Your bug will get fixed much faster if we can run your code and it doesn't have dependencies other than React. Paste the link to your JSFiddle (https://jsfiddle.net/Luktwrdm/) or CodeSandbox (https://codesandbox.io/s/new) example below:**
11-
12-
**What is the expected behavior?**
13-
14-
**Which versions of React, and which browser / OS are affected by this issue? Did this work in previous versions of React?**
4+
Note: to keep the backlog clean and actionable, issues may be immediately closed if they do not follow one of the above issue templates.
Lines changed: 41 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,41 @@
1+
---
2+
name: "🐛 Bug Report"
3+
about: Report a reproducible bug or regression.
4+
title: 'Bug: '
5+
labels: 'Status: Unconfirmed'
6+
7+
---
8+
9+
<!--
10+
Please provide a clear and concise description of what the bug is. Include
11+
screenshots if needed. Please test using the latest version of the relevant
12+
React packages to make sure your issue has not already been fixed.
13+
-->
14+
15+
React version:
16+
17+
## Steps To Reproduce
18+
19+
1.
20+
2.
21+
22+
<!--
23+
Your bug will get fixed much faster if we can run your code and it doesn't
24+
have dependencies other than React. Issues without reproduction steps or
25+
code examples may be immediately closed as not actionable.
26+
-->
27+
28+
Link to code example:
29+
30+
<!--
31+
Please provide a CodeSandbox (https://codesandbox.io/s/new), a link to a
32+
repository on GitHub, or provide a minimal code example that reproduces the
33+
problem. You may provide a screenshot of the application if you think it is
34+
relevant to your bug report. Here are some tips for providing a minimal
35+
example: https://stackoverflow.com/help/mcve.
36+
-->
37+
38+
## The current behavior
39+
40+
41+
## The expected behavior
Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
1+
---
2+
name: "📃 Documentation Issue"
3+
about: This issue tracker is not for documentation issues. Please file documentation issues at https://github.com/reactjs/reactjs.org.
4+
title: 'Docs: '
5+
labels: 'Resolution: Invalid'
6+
7+
---
8+
9+
🚨 This issue tracker is not for documentation issues. 🚨
10+
11+
The React website is hosted on a separate repository. You may let the
12+
team know about any issues with the documentation by opening an issue there:
13+
- https://github.com/reactjs/reactjs.org/issues/new

.github/ISSUE_TEMPLATE/question.md

Lines changed: 29 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,29 @@
1+
---
2+
name: "🤔 Questions and Help"
3+
about: This issue tracker is not for questions. Please ask questions at https://stackoverflow.com/questions/tagged/react.
4+
title: 'Question: '
5+
labels: 'Resolution: Invalid, Type: Question'
6+
7+
---
8+
9+
🚨 This issue tracker is not for questions. 🚨
10+
11+
As it happens, support requests that are created as issues are likely to be closed. We want to make sure you are able to find the help you seek. Please take a look at the following resources.
12+
13+
## Coding Questions
14+
15+
If you have a coding question related to React and React DOM, it might be better suited for Stack Overflow. It's a great place to browse through frequent questions about using React, as well as ask for help with specific questions.
16+
17+
https://stackoverflow.com/questions/tagged/react
18+
19+
## Talk to other React developers
20+
21+
There are many online forums which are a great place for discussion about best practices and application architecture as well as the future of React.
22+
23+
https://reactjs.org/community/support.html#popular-discussion-forums
24+
25+
## Proposals
26+
27+
If you'd like to discuss topics related to the future of React, or would like to propose a new feature or change before sending a pull request, please check out the discussions and proposals repository.
28+
29+
https://github.com/reactjs/rfcs

.github/PULL_REQUEST_TEMPLATE.md

Lines changed: 27 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,27 @@
1-
**Before submitting a pull request,** please make sure the following is done:
2-
3-
1. Fork [the repository](https://github.com/facebook/react) and create your branch from `master`.
4-
2. Run `yarn` in the repository root.
5-
3. If you've fixed a bug or added code that should be tested, add tests!
6-
4. Ensure the test suite passes (`yarn test`). Tip: `yarn test --watch TestName` is helpful in development.
7-
5. Run `yarn test-prod` to test in the production environment. It supports the same options as `yarn test`.
8-
6. If you need a debugger, run `yarn debug-test --watch TestName`, open `chrome://inspect`, and press "Inspect".
9-
7. Format your code with [prettier](https://github.com/prettier/prettier) (`yarn prettier`).
10-
8. Make sure your code lints (`yarn lint`). Tip: `yarn linc` to only check changed files.
11-
9. Run the [Flow](https://flowtype.org/) typechecks (`yarn flow`).
12-
10. If you haven't already, complete the CLA.
13-
14-
**Learn more about contributing:** https://reactjs.org/docs/how-to-contribute.html
1+
<!--
2+
Thanks for submitting a pull request!
3+
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
4+
5+
Before submitting a pull request, please make sure the following is done:
6+
7+
1. Fork [the repository](https://github.com/facebook/react) and create your branch from `master`.
8+
2. Run `yarn` in the repository root.
9+
3. If you've fixed a bug or added code that should be tested, add tests!
10+
4. Ensure the test suite passes (`yarn test`). Tip: `yarn test --watch TestName` is helpful in development.
11+
5. Run `yarn test-prod` to test in the production environment. It supports the same options as `yarn test`.
12+
6. If you need a debugger, run `yarn debug-test --watch TestName`, open `chrome://inspect`, and press "Inspect".
13+
7. Format your code with [prettier](https://github.com/prettier/prettier) (`yarn prettier`).
14+
8. Make sure your code lints (`yarn lint`). Tip: `yarn linc` to only check changed files.
15+
9. Run the [Flow](https://flowtype.org/) typechecks (`yarn flow`).
16+
10. If you haven't already, complete the CLA.
17+
18+
Learn more about contributing: https://reactjs.org/docs/how-to-contribute.html
19+
-->
20+
21+
## Summary
22+
23+
<!-- Explain the **motivation** for making this change. What existing problem does the pull request solve? -->
24+
25+
## Test Plan
26+
27+
<!-- Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes the user interface. -->

CHANGELOG.md

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,3 @@
1-
## [Unreleased]
2-
<details>
3-
<summary>
4-
Changes that have landed in master but are not yet released.
5-
Click to see more.
6-
</summary>
7-
</details>
8-
91
## 16.12.0 (November 14, 2019)
102

113
### React DOM

SECURITY.md

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
# Reporting Security Issues
2+
3+
If you believe you have found a security vulnerability in React, we encourage you to let us know right away. We will investigate all legitimate reports and do our best to quickly fix the problem.
4+
5+
Please refer to the following page for our responsible disclosure policy, reward guidelines, and those things that should not be reported:
6+
7+
https://www.facebook.com/whitehat

dangerfile.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -171,7 +171,7 @@ function git(args) {
171171

172172
for (let i = 0; i < baseArtifactsInfo.length; i++) {
173173
const info = baseArtifactsInfo[i];
174-
if (info.path === 'home/circleci/project/build/bundle-sizes.json') {
174+
if (info.path.endsWith('bundle-sizes.json')) {
175175
const resultsResponse = await fetch(info.url);
176176
previousBuildResults = await resultsResponse.json();
177177
break;

fixtures/dom/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
"classnames": "^2.2.5",
1212
"codemirror": "^5.40.0",
1313
"core-js": "^2.4.1",
14-
"jest-diff": "^24.8.0",
14+
"jest-diff": "^25.1.0",
1515
"prop-types": "^15.6.0",
1616
"query-string": "^4.2.3",
1717
"react": "^15.4.1",

0 commit comments

Comments
 (0)